From efc263651b2337c46ec18203728a0edad7543b0c Mon Sep 17 00:00:00 2001 From: Gaurav Harsha Date: Mon, 16 Feb 2026 16:34:21 -0500 Subject: [PATCH 1/2] update readme for latest updates for green-grids version checks. --- README.md | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/README.md b/README.md index a8bab59..7d5a10f 100644 --- a/README.md +++ b/README.md @@ -47,6 +47,7 @@ Class has to be parametrized with user defined `Dyson` type. `Dyson` publicly de - `solve(G&, Sigma1&, Sigma_tau&)` - for a given self-energies - `diff(G&, Sigma1&, Sigma_tau&)` - computes convergence creteria - `dump_iteration(int iter, const std::string&f)` - store additional data into a results file `f` for a given iteration `iter`. +- `std::string& get_grids_version()` - returns either the version of IR/Chebyshev transformation grid files if [`green-grids`](https://github.com/Green-Phys/green-grids.git) is used. Otherwise, it should return `green::grids::GRIDS_MIN_VERSION` as a placeholder. The method `solve` needs four parameters: @@ -79,6 +80,20 @@ public: } double diff(const G& g, const Sigma1& sigma1, const Sigma_tau& sigma_tau) { return _diff; } void dump_iteration(size_t iter, const std::string& result_file){}; + + /** + * @brief Returns a dummy min grids version used in IR / Chebyshev Fourier transformations + * NOTE: Ideally, the Dyson solver will depend on green-grids for IR / Chebyshev Fourier transformation; + * In that case, define a class variable: + * + * green::grids::transformer_t _ft; + * + * which is initialized as _ft(p) -- p being the green::params::params type + * And then, the function get_grids_version() should return + * + * _ft.get_version(); + */ + const std::string & get_grids_version() const { return green::grids::GRIDS_MIN_VERSION; } }; // define solver class From dcbd62f5ab22223bce9a514917bce323b768ec6f Mon Sep 17 00:00:00 2001 From: Gaurav Harsha Date: Mon, 16 Feb 2026 17:07:18 -0500 Subject: [PATCH 2/2] update the README for copilot reviews --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 7d5a10f..1f8bcb9 100644 --- a/README.md +++ b/README.md @@ -47,7 +47,7 @@ Class has to be parametrized with user defined `Dyson` type. `Dyson` publicly de - `solve(G&, Sigma1&, Sigma_tau&)` - for a given self-energies - `diff(G&, Sigma1&, Sigma_tau&)` - computes convergence creteria - `dump_iteration(int iter, const std::string&f)` - store additional data into a results file `f` for a given iteration `iter`. -- `std::string& get_grids_version()` - returns either the version of IR/Chebyshev transformation grid files if [`green-grids`](https://github.com/Green-Phys/green-grids.git) is used. Otherwise, it should return `green::grids::GRIDS_MIN_VERSION` as a placeholder. +- `const std::string& get_grids_version() const` - returns either the version of IR/Chebyshev transformation grid files if [`green-grids`](https://github.com/Green-Phys/green-grids.git) is used, otherwise, it should return `green::grids::GRIDS_MIN_VERSION` as a placeholder. The method `solve` needs four parameters: @@ -83,7 +83,7 @@ public: /** * @brief Returns a dummy min grids version used in IR / Chebyshev Fourier transformations - * NOTE: Ideally, the Dyson solver will depend on green-grids for IR / Chebyshev Fourier transformation; + * NOTE: Ideally, the Dyson solver depends on green-grids for IR / Chebyshev Fourier transformation; * In that case, define a class variable: * * green::grids::transformer_t _ft;