@@ -311,7 +311,7 @@ def off_grid_to_params(params: "OpenApiV1.OffGridParams") -> dict:
311311 """
312312 return {
313313 "param1" : "1" if params .off_grid_enabled else "0" ,
314- # Note: frequency and voltage require different commands, not implemented
314+ # Note: frequency and voltage require different commands, not implemented # noqa: E501
315315 }
316316
317317 @staticmethod
@@ -324,7 +324,7 @@ def power_to_params(params: "OpenApiV1.PowerParams") -> dict:
324324 """
325325 return {
326326 "param1" : str (params .active_power ),
327- # Note: reactive_power and power_factor require different commands, not implemented
327+ # Note: reactive_power and power_factor require different commands, not implemented # noqa: E501
328328 }
329329
330330 @staticmethod
@@ -427,7 +427,7 @@ def _process_response(
427427 """
428428 # Only write debug output if DEBUG environment variable is set to true
429429 if os .getenv ("DEBUG" , "false" ).lower () == "true" :
430- with open ("response.json" , "w" ) as f :
430+ with open ("response.json" , "w" ) as f : # noqa: PTH123
431431 json .dump (response , f , indent = 4 , sort_keys = True )
432432
433433 if response .get ("error_code" , 1 ) != 0 :
@@ -995,7 +995,8 @@ def min_read_parameter(self, device_sn: str, params: dict) -> dict:
995995 Args:
996996 device_sn (str): The ID of the TLX inverter.
997997 params (dict): Parameters for reading the setting.
998- Should include either 'parameter_id' or 'start_address' and 'end_address'.
998+ Should include either 'parameter_id' or 'start_address'
999+ and 'end_address'.
9991000
10001001 Returns:
10011002 dict: A dictionary containing the setting value.
@@ -1125,9 +1126,10 @@ def min_write_parameter(
11251126 parameters [i ] = str (value )
11261127 elif isinstance (parameter_values , dict ):
11271128 # Dict maps param positions to values
1129+ MAX_PARAMS = 19 # Maximum number of parameters supported
11281130 for pos , value in parameter_values .items ():
11291131 param_pos = int (pos ) if not isinstance (pos , int ) else pos
1130- if 1 <= param_pos <= 19 : # Validate parameter positions
1132+ if 1 <= param_pos <= MAX_PARAMS : # Validate parameter positions
11311133 parameters [param_pos ] = str (value )
11321134
11331135 # IMPORTANT: Create a data dictionary with ALL parameters explicitly included
@@ -1215,7 +1217,9 @@ def min_write_time_segment(
12151217 end_minute=0,
12161218 enabled=True
12171219 )
1218- api.write_parameter(device_sn, DeviceType.SPH_MIX, "mix_ac_discharge_time_period", params)
1220+ api.write_parameter(
1221+ device_sn, DeviceType.SPH_MIX, "mix_ac_discharge_time_period", params
1222+ )
12191223
12201224 # Backflow setting
12211225 params = api.BackflowSettingParams(
@@ -1292,7 +1296,7 @@ def write_time_segment(
12921296 all_params [param_key ] = ""
12931297
12941298 if os .getenv ("DEBUG" , "false" ).lower () == "true" :
1295- with open ("params.json" , "w" ) as f :
1299+ with open ("params.json" , "w" ) as f : # noqa: PTH123
12961300 json .dump (all_params , f , indent = 4 , sort_keys = True )
12971301
12981302 # Send the request
@@ -1305,7 +1309,7 @@ def write_time_segment(
13051309 response .json (), f"writing time segment command { command } "
13061310 )
13071311
1308- def write_parameter (
1312+ def write_parameter ( # noqa: PLR0912
13091313 self , device_sn : str , device_type : DeviceType , command : str , params : object
13101314 ) -> dict :
13111315 """
@@ -1347,14 +1351,21 @@ def write_parameter(
13471351 end_minute=0,
13481352 enabled=True
13491353 )
1350- api.write_parameter(device_sn, DeviceType.SPH_MIX, "mix_ac_discharge_time_period", params)
1354+ api.write_parameter(
1355+ device_sn,
1356+ DeviceType.SPH_MIX,
1357+ "mix_ac_discharge_time_period",
1358+ params,
1359+ )
13511360
13521361 # Backflow setting
13531362 params = api.BackflowSettingParams(
13541363 backflow_enabled=True,
13551364 anti_reverse_power_percentage=50
13561365 )
1357- api.write_parameter(device_sn, DeviceType.SPH_MIX, "backflow_setting", params)
1366+ api.write_parameter(
1367+ device_sn, DeviceType.SPH_MIX, "backflow_setting", params
1368+ )
13581369
13591370 """
13601371 url_prefix = DeviceType .get_url_prefix (device_type )
@@ -1418,7 +1429,7 @@ def write_parameter(
14181429 all_params [param_key ] = ""
14191430
14201431 if os .getenv ("DEBUG" , "false" ).lower () == "true" :
1421- with open ("params.json" , "w" ) as f :
1432+ with open ("params.json" , "w" ) as f : # noqa: PTH123
14221433 json .dump (all_params , f , indent = 4 , sort_keys = True )
14231434
14241435 # Send the request
@@ -1550,7 +1561,7 @@ def min_read_time_segments(
15501561
15511562 return segments
15521563
1553- def read_time_segments (
1564+ def read_time_segments ( # noqa: PLR0912
15541565 self , device_sn : str , device_type : DeviceType , settings_data : dict | None = None
15551566 ) -> list [dict ]:
15561567 """
0 commit comments