docs: Properties 번역 추가 #126
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @Yoonsoyoung02, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request by Yoonsoyoung02 translates section 2.13, 'Properties', of the Google Python Style Guide into Korean. The PR description specifies that 'properties' are translated as '프로퍼티' and 'attributes' as '속성' to distinguish between the two. The author also raises a point about handling linked sections within the document, specifically whether to include the original English links or wait until the corresponding Korean translations are available.
Highlights
- Translation: This PR provides a Korean translation of section 2.13 (Properties) of the Google Python Style Guide.
- Terminology: The translation distinguishes between 'properties' and 'attributes', translating them as '프로퍼티' and '속성' respectively.
- Links: The PR description mentions a consideration regarding how to handle links to other sections within the style guide, specifically whether to link to the original English versions or wait for the Korean translations to be completed.
Changelog
- Participation_guide.md
- Added a new file 'Participation_guide.md', which provides a guide for contributing to the Google Python Style Guide translation project.
- The guide includes information on selecting sections to translate, the translation process, submitting pull requests, and the review process.
- It also outlines the translation style guide, including principles for consistent terminology and maintaining code sections in English.
- Links to relevant resources such as the translation glossary and contribution guidelines are included.
- google python style guide/Properties.md
- Added a new file 'google python style guide/Properties.md', which contains the Korean translation of section 2.13 (Properties) of the Google Python Style Guide.
- The translation covers the definition, advantages, disadvantages, and recommendations for using properties in Python.
- It emphasizes the importance of using properties only when necessary and adhering to the expected behavior of attribute access.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Did you know?
The term 'property' in object-oriented programming refers to a member of a class that provides access to an attribute of an object. It allows you to control how the attribute is accessed and modified, enabling you to add validation, computation, or other logic.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request translates the 2.13 Properties section of the Google Python Style Guide into Korean. The translation seems well-done, and the translator has considered the distinction between properties and attributes, translating them as '프로퍼티' and '속성' respectively. The translator also raised a good point about handling linked sections within the document.
Merge Readiness
The translation appears to be accurate and well-considered. The translator has also identified a potential issue with linked sections and has proposed a solution. Overall, the pull request seems ready to be merged. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging.
|
@Yoonsoyoung02 |
|
그리고 지금 mkdocs 수정한 게 업로드가 안된 것 같은데 이것도 같이 수정해보겠습니다!! |
|
Gemini의 태클이 없으므로 /lgtm |
|
It looks like @GideokKim is using Here is the help message for the commands that I support: Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
GideokKim
left a comment
GideokKim
left a comment
There was a problem hiding this comment.
mkdocs 관련 문제만 해결해주시면 될 것 같습니다!
| - navigation.tabs # 상단 탭 네비게이션 | ||
| - navigation.sections # 섹션 접기/펼치기 | ||
| - navigation.top # "맨 위로" 버튼 | ||
| - search.suggest # 검색 제안 | ||
| - search.highlight # 검색 결과 하이라이트 | ||
| - content.tabs.link # 탭 간 이동 | ||
| - content.code.copy # 코드 복사 버튼 |
There was a problem hiding this comment.
mkdocs.yml 파일 전체 변경사항을 보시면 여러 줄에 걸쳐 변경사항이 생긴 것을 볼 수 있습니다. 이는 Visual Studio Code의 formatter 설정을 web 개발 배울 때 변경하면서 생긴 것으로 추측이 됩니다! formatter를 변경하거나 저장시 자동으로 format을 맞추는 옵션을 끄고 저장해주세요!
There was a problem hiding this comment.
@GideokKim
기덕님! 혹시 옵션 변경 후에 커밋까지 해야하나요? (내용 변경은 없습니다!)
There was a problem hiding this comment.
https://github.com/GideokKim/google-python-style-guide-kr/pull/126/files
여기 보시면 들여쓰기나 공백들이 많이 변경되었는데 이런 변경 없이 딱 새로 추가한 md 파일 부분만 변경 내용으로 있어야합니다! 그래서 다시 format을 맞춰서 커밋해주셔야해요!
There was a problem hiding this comment.
답변 감사해요!! 수정했습니다~!
There was a problem hiding this comment.
@Yoonsoyoung02 위에 드린 링크 계속 들어가서 확인해보세요! 수정된게 반영 안된듯합니다!
|
@Yoonsoyoung02 링크의 경우 원문의 링크를 우선 넣은 뒤에 1차적으로 모든 문서를 번역 후 2차에서 수정하는 것으로 하겠습니다! #98 이슈에 작업이 예정되어 있습니다! |
2 participants
본 PR은 2.13 Properties의 번역입니다.
Resolves #23 2.13 Propertie
• 특이사항
properties와 attributes의 구분을 위해 각각 아래와 같이 번역하였습니다.
properties → 프로퍼티 / attributes → 속성
• 검토사항
내용 중에 아래 이미지와 같이 링크로 연결된 부분이 있었습니다.
해당 부분에 원문 링크를 우선 삽입하면 될지 혹은 해당 부분 번역 완료 후 링크를 삽입할지 고민해봐야할 것 같습니다.
(현재는 링크를 넣지 않았습니다!)