Skip to content

fix(ai): stop typewriter animation on ai_indicator.stop #2918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arnautov-anton merged 2 commits into from
Jan 21, 2026
Merged

fix(ai): stop typewriter animation on ai_indicator.stop #2918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb757e4
Initial commit
arnautov-anton Jan 21, 2026
d0bfb10
Rename & behavior adjustment
arnautov-anton Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/components/AIStateIndicator/hooks/useAIState.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ export const AIStates = {
ExternalSources: 'AI_STATE_EXTERNAL_SOURCES',
Generating: 'AI_STATE_GENERATING',
Idle: 'AI_STATE_IDLE',
Stop: 'AI_STATE_STOP',
Thinking: 'AI_STATE_THINKING',
};

Expand Down Expand Up @@ -37,9 +38,17 @@ export const useAIState = (channel?: Channel): { aiState: AIState } => {
}
});

const indicatorStoppedListener = channel.on('ai_indicator.stop', (event) => {
const { cid } = event;
if (channel.cid === cid) {
Copy link
Contributor Author

@arnautov-anton arnautov-anton Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check is useless but I'm keeping it.

setAiState(AIStates.Stop);
}
});

return () => {
indicatorChangedListener.unsubscribe();
indicatorClearedListener.unsubscribe();
indicatorStoppedListener.unsubscribe();
};
}, [channel]);

Expand Down
13 changes: 10 additions & 3 deletions src/components/Message/StreamedMessageText.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import React from 'react';
import React, { useEffect } from 'react';

import type { MessageTextProps } from './MessageText';
import { MessageText } from './MessageText';

import { useMessageContext } from '../../context';
import { useChannelStateContext, useMessageContext } from '../../context';
import { useMessageTextStreaming } from './hooks';

export type StreamedMessageTextProps = Pick<
Expand All @@ -22,14 +22,21 @@ export const StreamedMessageText = (props: StreamedMessageTextProps) => {
streamingLetterIntervalMs,
} = props;
const { message: messageFromContext } = useMessageContext('StreamedMessageText');
const { channel } = useChannelStateContext();
const message = messageFromProps || messageFromContext;
const { text = '' } = message;
const { streamedMessageText } = useMessageTextStreaming({
const { skipAnimation, streamedMessageText } = useMessageTextStreaming({
renderingLetterCount,
streamingLetterIntervalMs,
text,
});

useEffect(() => {
channel?.on('ai_indicator.stop', () => {
skipAnimation();
});
}, [channel, skipAnimation]);

return (
<MessageText
message={{ ...message, text: streamedMessageText }}
Expand Down
12 changes: 10 additions & 2 deletions src/components/Message/hooks/useMessageTextStreaming.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { useEffect, useRef, useState } from 'react';

import { useStableCallback } from '../../../utils/useStableCallback';
import type { StreamedMessageTextProps } from '../StreamedMessageText';

export type UseMessageTextStreamingProps = Pick<
Expand All @@ -22,15 +23,17 @@ export const useMessageTextStreaming = ({
renderingLetterCount = DEFAULT_RENDERING_LETTER_COUNT,
streamingLetterIntervalMs = DEFAULT_LETTER_INTERVAL,
text,
}: UseMessageTextStreamingProps): { streamedMessageText: string } => {
}: UseMessageTextStreamingProps) => {
const [streamedMessageText, setStreamedMessageText] = useState<string>(text);
const textCursor = useRef<number>(text.length);

useEffect(() => {
const textLength = text.length;

const interval = setInterval(() => {
if (!text || textCursor.current >= textLength) {
clearInterval(interval);
return;
}
const newCursorValue = textCursor.current + renderingLetterCount;
const newText = text.substring(0, newCursorValue);
Expand All @@ -43,5 +46,10 @@ export const useMessageTextStreaming = ({
};
}, [streamingLetterIntervalMs, renderingLetterCount, text]);

return { streamedMessageText };
const skipAnimation = useStableCallback(() => {
textCursor.current = text.length;
setStreamedMessageText(text);
});

return { skipAnimation, streamedMessageText } as const;
};
Loading