fix: fix mypy

Author: javierdfm

stream_chat/async_chat/channel_batch_updater.py

@@ -1,4 +1,5 @@
-from typing import List
+import sys
+from typing import TYPE_CHECKING, List
 
 from stream_chat.types.channel_batch import (
     ChannelBatchMemberRequest,
@@ -8,13 +9,16 @@
 )
 from stream_chat.types.stream_response import StreamResponse
 
+if TYPE_CHECKING:
+    from stream_chat.async_chat.client import StreamChatAsync
+
 
 class ChannelBatchUpdater:
     """
     Provides convenience methods for batch channel operations (async).
     """
 
-    def __init__(self, client):
+    def __init__(self, client: "StreamChatAsync") -> None:
         self.client = client
 
     async def add_members(

stream_chat/async_chat/client.py

@@ -18,6 +18,7 @@
 )
 
 if TYPE_CHECKING:
+    from stream_chat.async_chat.channel_batch_updater import ChannelBatchUpdater
     from stream_chat.types.channel_batch import ChannelsBatchOptions
 from urllib.parse import urlparse
 
@@ -1033,7 +1034,7 @@ async def mark_delivered_simple(
         return await self.mark_delivered(data)
 
     async def update_channels_batch(
-        self, options: "ChannelsBatchOptions"
+        self, options: ChannelsBatchOptions
     ) -> StreamResponse:
         """
         Updates channels in batch based on the provided options.
@@ -1046,7 +1047,7 @@ async def update_channels_batch(
 
         return await self.put("channels/batch", data=options)
 
-    def channel_batch_updater(self) -> "ChannelBatchUpdater":
+    def channel_batch_updater(self) -> ChannelBatchUpdater:
         """
         Returns a ChannelBatchUpdater instance for batch channel operations.
 

stream_chat/channel_batch_updater.py

@@ -1,4 +1,5 @@
-from typing import List, Optional
+import sys
+from typing import TYPE_CHECKING, List, Optional
 
 from stream_chat.types.channel_batch import (
     ChannelBatchMemberRequest,
@@ -8,13 +9,16 @@
 )
 from stream_chat.types.stream_response import StreamResponse
 
+if TYPE_CHECKING:
+    from stream_chat.client import StreamChat
+
 
 class ChannelBatchUpdater:
     """
     Provides convenience methods for batch channel operations.
     """
 
-    def __init__(self, client):
+    def __init__(self, client: "StreamChat") -> None:
         self.client = client
 
     def add_members(

stream_chat/client.py

@@ -17,6 +17,7 @@
 from urllib.request import Request, urlopen
 
 if TYPE_CHECKING:
+    from stream_chat.channel_batch_updater import ChannelBatchUpdater
     from stream_chat.types.channel_batch import ChannelsBatchOptions
 
 from stream_chat.campaign import Campaign
@@ -999,7 +1000,7 @@ def mark_delivered_simple(
         }
         return self.mark_delivered(data=data)
 
-    def update_channels_batch(self, options: "ChannelsBatchOptions") -> StreamResponse:
+    def update_channels_batch(self, options: ChannelsBatchOptions) -> StreamResponse:
         """
         Updates channels in batch based on the provided options.
 
@@ -1011,7 +1012,7 @@ def update_channels_batch(self, options: "ChannelsBatchOptions") -> StreamRespon
 
         return self.put("channels/batch", data=options)
 
-    def channel_batch_updater(self) -> "ChannelBatchUpdater":
+    def channel_batch_updater(self) -> ChannelBatchUpdater:
         """
         Returns a ChannelBatchUpdater instance for batch channel operations.
 

stream_chat/tests/async_chat/test_channel_batch_updater.py

@@ -93,18 +93,23 @@ async def test_channel_batch_updater_add_members(
                     continue
 
                 if task["status"] == "completed":
-                    # Wait a bit and verify members were added
+                    # Wait a bit and verify members were added to both channels
                     for _ in range(120):
                         await asyncio.sleep(1)
                         ch1_members = await ch1.query_members({})
                         ch2_members = await ch2.query_members({})
 
                         ch1_member_ids = [m["user_id"] for m in ch1_members]
-                        all_found = all(
+                        ch2_member_ids = [m["user_id"] for m in ch2_members]
+                        all_found_ch1 = all(
                             user_id in ch1_member_ids
                             for user_id in [u["id"] for u in users_to_add]
                         )
-                        if all_found:
+                        all_found_ch2 = all(
+                            user_id in ch2_member_ids
+                            for user_id in [u["id"] for u in users_to_add]
+                        )
+                        if all_found_ch1 and all_found_ch2:
                             return
 
                     pytest.fail("changes not visible after 2 minutes")

stream_chat/tests/test_channel_batch_updater.py

@@ -90,18 +90,23 @@ def test_channel_batch_updater_add_members(
                     continue
 
                 if task["status"] == "completed":
-                    # Wait a bit and verify members were added
+                    # Wait a bit and verify members were added to both channels
                     for _ in range(120):
                         time.sleep(1)
                         ch1_members = ch1.query_members({})
                         ch2_members = ch2.query_members({})
 
                         ch1_member_ids = [m["user_id"] for m in ch1_members]
-                        all_found = all(
+                        ch2_member_ids = [m["user_id"] for m in ch2_members]
+                        all_found_ch1 = all(
                             user_id in ch1_member_ids
                             for user_id in [u["id"] for u in users_to_add]
                         )
-                        if all_found:
+                        all_found_ch2 = all(
+                            user_id in ch2_member_ids
+                            for user_id in [u["id"] for u in users_to_add]
+                        )
+                        if all_found_ch1 and all_found_ch2:
                             return
 
                     pytest.fail("changes not visible after 2 minutes")

stream_chat/types/channel_batch.py

@@ -74,13 +74,13 @@ class ChannelsBatchFilters(TypedDict, total=False):
     filter_tags: Optional[Any]
 
 
-class ChannelsBatchOptions(TypedDict):
+class ChannelsBatchOptions(TypedDict, total=False):
     """
     Represents options for batch channel updates.
 
     Parameters:
-        operation: The batch operation to perform.
-        filter: The filter to match channels.
+        operation: The batch operation to perform (required).
+        filter: The filter to match channels (required).
         members: List of members for member-related operations (optional).
         data: Channel data updates for updateData operation (optional).
         filter_tags_update: List of filter tags for filter tag operations (optional).