Skip to content
This repository was archived by the owner on Apr 2, 2026. It is now read-only.
This repository was archived by the owner on Apr 2, 2026. It is now read-only.

Bugs/ missing events #10

@harsh-98

Description

@harsh-98
  • no events are emitted in the contract-register or the marketconfiugurator in v3.1 for addpool or addcreditmanager. for pools, i can use createmarket event, so addpool is not needed. But for creditmanager no event is emitted. Emit CreateCreditManager(creditmanager) event in deployCreditManager atlteast.

  • trusted param is of no use in setPriceFeedFromStore in marketconfigurator? explanation needed.

  • In the newPriceOraclev3.sol, we don’t maintain useReserve field. We emit setPriceFeed if the price feed is main, and setReservePriceFeed if the price feed is reserve. Since there is no useReserve we can’t switch btw the price feed so how can we use reserve price when needed? and SetReservePriceFeedStatus is also removed. so how to we switch btw them.

  • in changePriceOracle priceoracle[pool] is not updated to new address and u should emit SetPriceOracle(pool, priceoracle) event. This event should also be emitted in createmarket.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions