diff --git a/app/controllers/admin/submissions_controller.rb b/app/controllers/admin/submissions_controller.rb index 0bb14edc1..da117ba31 100644 --- a/app/controllers/admin/submissions_controller.rb +++ b/app/controllers/admin/submissions_controller.rb @@ -220,7 +220,17 @@ def set_submission end def status_params - params.permit(:aasm_state) + permitted_params = params.permit(:aasm_state) + + if permitted_params[:aasm_state].present? + unless Submission.aasm.states.map(&:name).include?(permitted_params[:aasm_state].to_sym) + raise ActionController::ParameterMissing, "Invalid state: #{permitted_params[:aasm_state]}" + end + else + raise ActionController::ParameterMissing, "aasm_state parameter is missing" + end + + permitted_params end def tag_params diff --git a/app/models/submission.rb b/app/models/submission.rb index 734dc3b74..484a7c657 100644 --- a/app/models/submission.rb +++ b/app/models/submission.rb @@ -62,6 +62,7 @@ def validate_custom_form answered_questions.delete('language') answered_questions.delete('referer') answered_questions.delete('aasm_state') + answered_questions.delete('tags') answered_questions.delete('spam_score') answered_questions.delete('created_at') answered_questions.delete('updated_at') diff --git a/app/views/admin/submissions/_status_form.html.erb b/app/views/admin/submissions/_status_form.html.erb index 41b825843..b550300fa 100644 --- a/app/views/admin/submissions/_status_form.html.erb +++ b/app/views/admin/submissions/_status_form.html.erb @@ -12,7 +12,7 @@
    <% @submission.aasm.states.each do |state| %>
  1. -

    +

    "> <%= state.name.capitalize %> diff --git a/app/views/admin/submissions/show.html.erb b/app/views/admin/submissions/show.html.erb index 2a91e956a..a91ab9db1 100644 --- a/app/views/admin/submissions/show.html.erb +++ b/app/views/admin/submissions/show.html.erb @@ -36,7 +36,7 @@ - <%= link_to(@submission.form.organization.name, admin_organization_path(@submission.form.organization)) %> + <%= render "admin/organizations/badge", organization: @submission.form.organization %>