Various parameter checking issues

[mirenradia]

ChomboParameters::warn_array_parameter is calling check_parameter rather than warn_parameter. This is incorrect.

Also, when called in BinaryBH/SimulationParameters.hpp, it using bh1_params.mass in the validity check for momentumB rather than bh2_params.mass.

I've also realised that there are some checks in the TwoPunctures part which are implemented in a non-standard way and should be changed to the standard check_parameter. This parameter loading code is duplicated in the standalone TwoPunctures example. Ideally, the parameter loading code for TwoPunctures params should be in a function in the TwoPunctures repository which can be called in the BinaryBH example.

[mirenradia]

A warning should also be added that the restart file time is strictly less than the stop_time parameter (yes I did just accidentally submit a job with a stop_time that was the same as the restart file time and wasted its time in the queue).

[KAClough]

It would be useful to check whether TWOPUNCTURES_SOURCE is set, and if so also check if a mandatory TwoPunctures param (e.g. TP_momentum_plus ) exists in the parameter file and then print an error message like “You are running with TwoPunctures, make sure the TwoPunctures params are set or unset TWOPUNCTURES_SOURCE and recompile.”

It is easy to forget that you set TP and then wonder why it is looking for the params for that...

[mirenradia]

Another thing I have just noticed is this line which should default vars_parity_diagnostic to an enum value from the parity enum rather than the BC Type enum.