`Page` properties not eagerly loaded

[tomudding]

Current behaviour

Currently, the properties of a Page are not eagerly loaded. As a result, each property is manually queried (at least in symfony + doctrine/orm v3.5.7).

Desired behaviour

Add fetch: 'EAGER'.

Steps to reproduce

See developer tools for number of queries

Website version

GEWISWEB-ng

What operating system(s) are you seeing the problem on?

No response

What browser(s) are you seeing the problem on?

No response

Other information

No response

[tomudding]

This requires more changes, because

https://github.com/tomudding/gewisweb-ng/blob/a99f19d78d4afbd60daab8fb85b94b3312ec0400/src/Repository/Frontpage/PageRepository.php#L38-L43

is no longer possible:

Associations with fetch-mode=EAGER may not be using WITH conditions in "App\Entity\Frontpage\Page#category".

We can circumvent this by moving the conditions to separate WHERE clauses:

        // ...
        $qb = $this->createQueryBuilder('p')
            ->innerJoin('p.category', 'c') // no WITH
            ->innerJoin('p.subCategory', 's') // no WITH
            ->innerJoin('p.name', 'n'); // no WITH

        // Add conditions in WHERE instead (EAGER fetch is incompatible with an innerJoin using WITH for conditionals).
        $qb->where('c.value' . $queryLanguage . ' = :category')
            ->setParameter('category', $category);

        if ($subCategory !== null) {
            $qb->andWhere('s.value' . $queryLanguage . ' = :subCategory')
                ->setParameter('subCategory', $subCategory);
        } else {
            $qb->andWhere('s.value' . $queryLanguage . ' IS NULL');
        }
        // ...

[tomudding]

Applying the above change reduces the number of queries for a custom page load by 7.