-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Description
Currently, the PVTPackage relies on ASSERTs to throw errors when the input data is not what is expected. There are two issues with the current behavior:
- These
ASSERTs are only executed inDebug, but if something unexpected happens in thePVTPackagewe should terminate the simulation both inReleaseand inDebug. - Some
ASSERTs could be removed. For instance, in addition to theASSERTs removed in PR Removed ASSERT preventing from running tutorials in Debug #34, I would also remove theASSERTchecking that the pressures are in the table range:
https://github.com/GEOSX/PVTPackage/blob/e875eaae87bad4504db89c28dc00837e7ebda891/PVTPackage/source/MultiphaseSystem/PhaseModel/BlackOil/DeadOil_PhaseModel.cpp#L104
and just make sure that if a pressure is outside the table, then we use the first/last value in the table to interpolate in the table (as for relative permeabilities for instance). We could have alogLevelthat could be used to decide whether a warning is issued when the pressure is outside the table.
Metadata
Metadata
Assignees
Labels
No labels