Skip to content

Negative Evaluation Metric? #24

@Neph0s

Description

@Neph0s

I found that metrics like em, f1 can be negative during initial evaluation.

This is due to the fact that metrics calculation share the same function as reward calculation. Howver, reward is set to -1 when there is a format error. Hence, we may also get -1 score in evaluation. However, i think this should be improved. We should change verl/trainer/ppo/ray_trainer.py, in _validate() :

reward_tensor = torch.clamp(reward_tensor, min=0.0)

reward_tensor = torch.clamp(reward_tensor, min=0.0) em_reward_tensor = torch.clamp(em_reward_tensor, min=0.0) llm_reward_tensor = torch.clamp(llm_reward_tensor, min=0.0)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions