Push users to educate themselves about comparing strings in .NET

[dawedawe]

See G-Research/ApiSurface#43 (comment)

[Numpsy]

A question about string analyzers (StartsWith, EndsWith etc) - In C# (NetAnalyzers) there is an analyzer that prompts you to use the char overloads of the functions instead of the string ones when calling them with a string literal that is only a single character - https://learn.microsoft.com/en-gb/dotnet/fundamentals/code-analysis/quality-rules/ca1865-ca1867 - Are there any thoughts on trying to implement that functionality in the string analyzer here?

[nojaf]

This didn't really came up at the time.
It does seem like the same ballpark.
@Smaug123 would you accept a potential PR here, or do we want to leave that for the community analyzers?

[Smaug123]

I think that seems very reasonable for us to have - recommending the simpler API.

[Numpsy]

Ok, I'll try to have a look when I get some time.

On a related subject - the NetAnalyzers analyzer seems to suggest adding an explicit StringComparison parameter on calls to both IndexOf and LastIndexOf and the analyzer here only seems to do IndexOf - is that intentional?

[Smaug123]

Just an unintended omission, I think!