Skip to content

[ENHANCEMENT/FIX] Add extensions and optional fields parsing and fix class syntax parsing for typedefs. #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Starexify wants to merge 2 commits into
base: experimental
Choose a base branch
from
Open

[ENHANCEMENT/FIX] Add extensions and optional fields parsing and fix class syntax parsing for typedefs. #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69553d2
Add extensions and optional fields parsing for typedefs.
Starexify Jan 26, 2026
7fd526c
Fix class syntax parsing for typedefs
Starexify Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions polymod/hscript/_internal/Expr.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,7 @@ typedef EnumArgDecl =
typedef TypeDecl =
{
> ModuleType,
var extensions:Array<CType>;
var t:CType;
}

Expand Down
40 changes: 39 additions & 1 deletion polymod/hscript/_internal/Parser.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1197,20 +1197,45 @@ class Parser
while (true)
{
t = token();

// Skip modifiers to allow vars in typedefs to be parsed without issues
// Only handle field access when it gets implemented
switch(t)
{
case TId("public"), TId("private"):
t = token();
default:
}

switch (t)
{
case TBrClose: break;
case TId("var"), TId("final"):
var isOpt = maybe(TQuestion);
var name = getIdent();
ensure(TDoubleDot);
var type = parseType();
if (isOpt) type = CTOpt(type);
if (t.match(TId("final")))
{
if (meta == null) meta = [];
meta.push({name: ":final", params: []});
}
fields.push({name: name, t: parseType(), meta: meta});
fields.push({name: name, t: type, meta: meta});
meta = null;
ensure(TSemicolon);
case TQuestion:
var name = getIdent();
ensure(TDoubleDot);
fields.push({name: name, t: CTOpt(parseType()), meta: meta});
meta = null;
t = token();
switch (t)
{
case TComma:
case TBrClose: break;
default: unexpected(t);
}
case TId(name):
ensure(TDoubleDot);
fields.push({name: name, t: parseType(), meta: meta});
Expand Down Expand Up @@ -1450,13 +1475,26 @@ class Parser
var name = getIdent();
var params = parseParams();
ensureToken(TOp("="));

var extensions = [];
if (maybe(TBrOpen))
{
while (maybe(TOp(">")))
{
extensions.push(parseType());
maybe(TComma);
}
push(TBrOpen);
}

var t = parseType();
return DTypedef(
{
name: name,
meta: meta,
params: params,
isPrivate: isPrivate,
extensions: extensions,
t: t,
});
case "enum":
Expand Down