Investigate the frequent requests to the database to load user information

[csharpfritz]

ASP.NET appears to be querying the user record in the database very frequently. Can we minimize this interaction?

[degenone]

I looked into this a bit. When I changed the following, the user queries were far less frequent.

1. SharpSite.Security.Postgres/IdentityUserAccessor.cs

 internal sealed class IdentityUserAccessor(UserManager<PgSharpSiteUser> userManager, IdentityRedirectManager redirectManager)
 {
+       private static PgSharpSiteUser? _User;
        public async Task<PgSharpSiteUser> GetRequiredUserAsync(HttpContext context)
        {
-               var user = await userManager.GetUserAsync(context.User);
+               if (_User is not null) return _User;
+               _User = await userManager.GetUserAsync(context.User);

-               if (user is null)
+               if (_User is null)
                {
                        redirectManager.RedirectToWithStatus("Account/InvalidUser", $"Error: Unable to load user with ID '{userManager.GetUserId(context.User)}'.", context);
                }

-               return user;
+               return _User;
        }
 }

2. SharpSite.Security.Postgres/UserRepository.cs

-       private SharpSiteUser CurrentUser = null!;
+       private static SharpSiteUser CurrentUser = null!;

However, the E2E tests currently don't pass. I'll try to investigate the issue later, but if anyone else wants to look into it in the meantime, feel free to do so.

E2E test results

  SharpSite.E2E test failed with 1 error(s) (11,3s)
    /_/src/Playwright/Core/AssertionsBase.cs(87): error TESTERROR:
      SharpSite.E2E.ProfileTests.CanChangePhoneNumber (6s 164ms): Error Message: Microsoft.Playwright.PlaywrightException : Locator expected to have value '
      3036847977'
      But was: '<element(s) not found>'
      Call log:
        -   - LocatorAssertions.ToHaveValueAsync with timeout 5000ms
        -   - waiting for GetByPlaceholder("Enter your phone number")
      Stack Trace:
         at Microsoft.Playwright.Core.AssertionsBase.ExpectImplAsync(String expression, FrameExpectOptions expectOptions, Object expected, String message) i
      n /_/src/Playwright/Core/AssertionsBase.cs:line 87
         at Microsoft.Playwright.Core.AssertionsBase.ExpectImplAsync(String expression, ExpectedTextValue[] expectedText, Object expected, String message, F
      rameExpectOptions options) in /_/src/Playwright/Core/AssertionsBase.cs:line 65
         at Microsoft.Playwright.Core.AssertionsBase.ExpectImplAsync(String expression, ExpectedTextValue textValue, Object expected, String message, FrameE
      xpectOptions options) in /_/src/Playwright/Core/AssertionsBase.cs:line 57
         at SharpSite.E2E.ProfileTests.CanChangePhoneNumber() in C:\Users\terpp\dev\SharpSite\e2e\SharpSite.E2E\ProfileTests.cs:line 37
      --- End of stack trace from previous location ---

Test summary: total: 6; failed: 1; succeeded: 5; skipped: 0; duration: 11,3s
Build failed with 1 error(s) in 13,4s
Playwright tests failed!