finops: fix broken test workflow (100% failure rate)

[laurigates]

Problem

The OLMap test workflow has a 100% failure rate — all 3 runs in the March 1–4 period failed. Every trigger consumes minutes with zero value.

Proposed Solution

1. Investigate the test failure: gh run view --log-failed on a recent run
2. Fix the test configuration or dependencies
3. If not fixable short-term, disable the workflow until resolved

Context

Identified via /finops:workflows analysis on 2026-03-04.

🤖 Generated with Claude Code

[laurigates]

• Let's work on this by following the suggested solution
• Research latest documentation and best practices

@claude

[claude]

Claude finished @laurigates's task in 11m 23s —— View job • claude/issue-77-20260320-2010 • Create PR ➔

---

Fixing broken test workflow

• Gather context: read workflow files and understand failures
• Analyze root cause of test failures
• Fix .pre-commit-config.yaml biome hook (root cause)
• Document required test.yml changes (workflow file — cannot push directly)
• Commit and push changes

Root cause analysis

Two issues identified:

Issue 1 (primary — causes 100% failure): biome-format pre-commit hook broken in CI

The .pre-commit-config.yaml had a local biome-format hook using language: system that ran:

bash -c 'cd react_ui && npx @biomejs/biome format --write "${@#react_ui/}"' --

In the CI pre-commit job, react_ui/node_modules is never installed (no npm ci step). In npm v7+, npx does not auto-install packages non-interactively without --yes, so npx @biomejs/biome fails when biome isn't found locally. This caused the pre-commit job to fail on every run → backend and frontend jobs (which have needs: pre-commit) are skipped → 100% workflow failure.

Fix applied in .pre-commit-config.yaml: Changed to language: node with additional_dependencies. Pre-commit manages the biome installation in its own node virtualenv — no npm ci in CI needed:

- id: biome-format
  name: biome format
  entry: biome format --write
  language: node
  additional_dependencies: ['@biomejs/biome@2.3.14']
  files: ^react_ui/.*\.(js|jsx|ts|tsx|json)$
  exclude: ^react_ui/(build|node_modules|package-lock\.json)

Also excluded package-lock.json from biome formatting to prevent the machine-generated lock file from being altered.

---

Issue 2 (secondary): actions/setup-node@v6 in test.yml

test.yml line 116 uses actions/setup-node@v6. As of my knowledge, the latest stable major version of this action is v4. If v6 does not exist, the frontend job will fail even once pre-commit is fixed.

⚠️ I cannot push changes to .github/workflows/ files (GitHub App token lacks workflows permission). Please apply this change manually:

-        uses: actions/setup-node@v6
+        uses: actions/setup-node@v4

---

Summary

The .pre-commit-config.yaml fix is pushed and should resolve the 100% failure rate. Please also manually update test.yml line 116 to use actions/setup-node@v4.

|