Improvement

[Leinad4Mind]

Hi there, it would be great if we could deactivate the reminder. In case we want to delete all users with more then 30 days without sending reminders.

Thnks in advance!

(fF there is too an easey way to change the code to acheive this, please do tell)

[ForumHulp]

Just disable the extension, delete and enable it again

[Leinad4Mind]

Hum, and that will make it delete all inactive users without sending reminder? oO How come?

For what I read and understood, this extension send a reminder after X days (30 by default) and at least 7 days after it deletes the users.

I tried to delete the 7 days since it was hardcoded with an unix time, and put it +100 instead so it would force the delete when it sends the reminder, but it doesn't delete any user and it appears on the logs that there isn't any inactive user (when there is many)

[Leinad4Mind]

I've check the SQL and it seems I don't have the user_new = 1, what does that column means? It doesnt appear here: https://wiki.phpbb.com/Table.phpbb_users how strange...

[Leinad4Mind]

Ok, I saw that if I have "New member post limit:" to 0, then I'll not have the Newly Registered Users group and therefor the user_new will be 0 and not 1. So maybe the sql is wrong and we should remove the user_new from it. At leasts for me it worked. ;)

[ForumHulp]

This extension is meant to delete users who registered but never came back again. They have this new collumn filled with 1.

[Leinad4Mind]

But all users that was inactive, never came back again, there was no login date, nothing. It was bots registrations that never logged in. I've then tried on another forum and it worked and the difference between the 2 foruns was that one had the "New member post limit:" to 0, disabling the newly registered group (nrg), so in my opinion the user_new is 1 when we're using the nrg, and go to 0 when the user is out the NRG (after some posts). Or if we've disabled the NRG to be used then all users registration will come with user_new = 0. So it doesnt make sense to use the user_new on the sql orelse this ext will never work on forums that doesnt make use of the NRG. Or that in the past didnt make use of it. After remove the user_new = 1 from the sql, the extension worked perfectly on the other board that didnt used NRG.

Ok, it seems I was right about the user_new being related to the NRG: https://www.phpbb.com/community/viewtopic.php?p=15075281#p15075281

[Leinad4Mind]

About the improvement I asked, I edited the while code on the cron file to this:
`while ($row = $this->db->sql_fetchrow($result))
{
$delete_list[$row['user_id']] = $row['username'];
unset($msg_list[$row['user_id']]);

	}`

And now it doesnt send any reminder and the users get deleted automatically after 30 days.
This could be an option at acp, to disable the reminder, since for me and I beleive for many others admins, we sometimes want to delete all inactive users and not send a reminder.

[ForumHulp]

Can you test it with this version