Skip to content

General Code Cleanup! #53

@trentgoing

Description

@trentgoing

Good stuff!  Beyond the other issues opened that have specific code review commentary, please take some time to look through the following before the end of your project!

  • Informative Readme - check Learn for more details but the Readme will be the welcome mat for your project.  Update it to convey whatever you hope the reader should know.

  • Variable declaration - When and why are you using var or let?  Should some variables be const?

  • Variable/file naming conventions - Are your variables and components named appropriately?  Things may have changed significantly from the time you first defined them to the end.  Make sure the names still make sense.

  • Specific, testable functions - Are you breaking functionality down enough?  Can important functionality be discretely verified or is it part of a larger class or method?  

  • Testing - Are your tests meaningful?  What are the critical parts of your application, and are they covered?

  • Error Handling - How are errors being caught?  Are errors thrown descriptive and helpful?

  • Logging - console.log statements should probably be removed.

Further Reading:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions