Skip to content

Commit 9cbfb2b

Browse files
fix: path interpolation template strings (#90)
1 parent bc9989c commit 9cbfb2b

File tree

9 files changed

+14
-14
lines changed

9 files changed

+14
-14
lines changed

lib/finch-api/resources/hris/benefits.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def create(params = {})
4646
def retrieve(benefit_id, params = {})
4747
@client.request(
4848
method: :get,
49-
path: ["employer/benefits/%0s", benefit_id],
49+
path: ["employer/benefits/%1$s", benefit_id],
5050
model: FinchAPI::Models::HRIS::CompanyBenefit,
5151
options: params[:request_options]
5252
)
@@ -67,7 +67,7 @@ def update(benefit_id, params = {})
6767
parsed, options = FinchAPI::Models::HRIS::BenefitUpdateParams.dump_request(params)
6868
@client.request(
6969
method: :post,
70-
path: ["employer/benefits/%0s", benefit_id],
70+
path: ["employer/benefits/%1$s", benefit_id],
7171
body: parsed,
7272
model: FinchAPI::Models::HRIS::UpdateCompanyBenefitResponse,
7373
options: options

lib/finch-api/resources/hris/benefits/individuals.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def enroll_many(benefit_id, params = {})
2323
parsed, options = FinchAPI::Models::HRIS::Benefits::IndividualEnrollManyParams.dump_request(params)
2424
@client.request(
2525
method: :post,
26-
path: ["employer/benefits/%0s/individuals", benefit_id],
26+
path: ["employer/benefits/%1$s/individuals", benefit_id],
2727
body: parsed[:individuals],
2828
page: FinchAPI::SinglePage,
2929
model: FinchAPI::Models::HRIS::Benefits::EnrolledIndividual,
@@ -43,7 +43,7 @@ def enroll_many(benefit_id, params = {})
4343
def enrolled_ids(benefit_id, params = {})
4444
@client.request(
4545
method: :get,
46-
path: ["employer/benefits/%0s/enrolled", benefit_id],
46+
path: ["employer/benefits/%1$s/enrolled", benefit_id],
4747
model: FinchAPI::Models::HRIS::Benefits::IndividualEnrolledIDsResponse,
4848
options: params[:request_options]
4949
)
@@ -66,7 +66,7 @@ def retrieve_many_benefits(benefit_id, params = {})
6666
FinchAPI::Models::HRIS::Benefits::IndividualRetrieveManyBenefitsParams.dump_request(params)
6767
@client.request(
6868
method: :get,
69-
path: ["employer/benefits/%0s/individuals", benefit_id],
69+
path: ["employer/benefits/%1$s/individuals", benefit_id],
7070
query: parsed,
7171
page: FinchAPI::SinglePage,
7272
model: FinchAPI::Models::HRIS::Benefits::IndividualBenefit,
@@ -89,7 +89,7 @@ def unenroll_many(benefit_id, params = {})
8989
parsed, options = FinchAPI::Models::HRIS::Benefits::IndividualUnenrollManyParams.dump_request(params)
9090
@client.request(
9191
method: :delete,
92-
path: ["employer/benefits/%0s/individuals", benefit_id],
92+
path: ["employer/benefits/%1$s/individuals", benefit_id],
9393
body: parsed,
9494
page: FinchAPI::SinglePage,
9595
model: FinchAPI::Models::HRIS::Benefits::UnenrolledIndividual,

lib/finch-api/resources/hris/documents.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def list(params = {})
4646
def retreive(document_id, params = {})
4747
@client.request(
4848
method: :get,
49-
path: ["employer/documents/%0s", document_id],
49+
path: ["employer/documents/%1$s", document_id],
5050
model: FinchAPI::Models::HRIS::DocumentRetreiveResponse,
5151
options: params[:request_options]
5252
)

lib/finch-api/resources/jobs/automated.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ def create(params)
5151
def retrieve(job_id, params = {})
5252
@client.request(
5353
method: :get,
54-
path: ["jobs/automated/%0s", job_id],
54+
path: ["jobs/automated/%1$s", job_id],
5555
model: FinchAPI::Models::Jobs::AutomatedAsyncJob,
5656
options: params[:request_options]
5757
)

lib/finch-api/resources/jobs/manual.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class Manual
1717
def retrieve(job_id, params = {})
1818
@client.request(
1919
method: :get,
20-
path: ["jobs/manual/%0s", job_id],
20+
path: ["jobs/manual/%1$s", job_id],
2121
model: FinchAPI::Models::Jobs::ManualAsyncJob,
2222
options: params[:request_options]
2323
)

lib/finch-api/resources/payroll/pay_groups.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ class PayGroups
1616
def retrieve(pay_group_id, params = {})
1717
@client.request(
1818
method: :get,
19-
path: ["employer/pay-groups/%0s", pay_group_id],
19+
path: ["employer/pay-groups/%1$s", pay_group_id],
2020
model: FinchAPI::Models::Payroll::PayGroupRetrieveResponse,
2121
options: params[:request_options]
2222
)

lib/finch-api/resources/sandbox/employment.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ def update(individual_id, params = {})
5757
parsed, options = FinchAPI::Models::Sandbox::EmploymentUpdateParams.dump_request(params)
5858
@client.request(
5959
method: :put,
60-
path: ["sandbox/employment/%0s", individual_id],
60+
path: ["sandbox/employment/%1$s", individual_id],
6161
body: parsed,
6262
model: FinchAPI::Models::Sandbox::EmploymentUpdateResponse,
6363
options: options

lib/finch-api/resources/sandbox/individual.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def update(individual_id, params = {})
4646
parsed, options = FinchAPI::Models::Sandbox::IndividualUpdateParams.dump_request(params)
4747
@client.request(
4848
method: :put,
49-
path: ["sandbox/individual/%0s", individual_id],
49+
path: ["sandbox/individual/%1$s", individual_id],
5050
body: parsed,
5151
model: FinchAPI::Models::Sandbox::IndividualUpdateResponse,
5252
options: options

lib/finch-api/util.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -253,9 +253,9 @@ def interpolate_path(path)
253253
path
254254
in []
255255
""
256-
in [String, *interpolations]
256+
in [String => p, *interpolations]
257257
encoded = interpolations.map { ERB::Util.url_encode(_1) }
258-
path.first % encoded
258+
format(p, *encoded)
259259
end
260260
end
261261
end

0 commit comments

Comments
 (0)