Skip to content

Commit 81414ea

Browse files
chore(internal): more concise handling of parameter naming conflicts (#127)
1 parent 695363a commit 81414ea

File tree

3 files changed

+5
-8
lines changed

3 files changed

+5
-8
lines changed

lib/finch_api/internal/type/base_model.rb

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,6 @@ def dump(value)
265265
return super
266266
end
267267

268-
is_param = singleton_class <= FinchAPI::Internal::Type::RequestParameters::Converter
269268
acc = {}
270269

271270
coerced.each do |key, val|
@@ -274,21 +273,19 @@ def dump(value)
274273
in nil
275274
acc.store(name, super(val))
276275
else
277-
mode, type_fn = field.fetch_values(:mode, :type_fn)
276+
api_name, mode, type_fn = field.fetch_values(:api_name, :mode, :type_fn)
278277
case mode
279278
in :coerce
280279
next
281280
else
282281
target = type_fn.call
283-
api_name = is_param ? name : field.fetch(:api_name)
284282
acc.store(api_name, FinchAPI::Internal::Type::Converter.dump(target, val))
285283
end
286284
end
287285
end
288286

289-
known_fields.each do |name, field|
290-
mode, const = field.fetch_values(:mode, :const)
291-
api_name = is_param ? name : field.fetch(:api_name)
287+
known_fields.each_value do |field|
288+
api_name, mode, const = field.fetch_values(:api_name, :mode, :const)
292289
next if mode == :coerce || acc.key?(api_name) || const == FinchAPI::Internal::OMIT
293290
acc.store(api_name, const)
294291
end

lib/finch_api/resources/hris/company/pay_statement_item/rules.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ def update(rule_id, params = {})
5555
@client.request(
5656
method: :put,
5757
path: ["employer/pay-statement-item/rule/%1$s", rule_id],
58-
body: parsed.transform_keys(optional_property: :optionalProperty),
58+
body: parsed,
5959
model: FinchAPI::Models::HRIS::Company::PayStatementItem::RuleUpdateResponse,
6060
options: options
6161
)

lib/finch_api/resources/request_forwarding.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ def forward(params)
2525
@client.request(
2626
method: :post,
2727
path: "forward",
28-
body: parsed.transform_keys(method_: :method),
28+
body: parsed,
2929
model: FinchAPI::Models::RequestForwardingForwardResponse,
3030
options: options
3131
)

0 commit comments

Comments
 (0)