Skip to content

Commit 4e15ab3

Browse files
fix!: use descriptive prefixes for enum names that start with otherwise illegal identifiers (#102)
1 parent 7aec958 commit 4e15ab3

File tree

9 files changed

+27
-27
lines changed

9 files changed

+27
-27
lines changed

lib/finch_api/models/hris/benefit_type.rb

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@ module HRIS
77
module BenefitType
88
extend FinchAPI::Enum
99

10-
NUMBER_401K = :"401k"
11-
NUMBER_401K_ROTH = :"401k_roth"
12-
NUMBER_401K_LOAN = :"401k_loan"
13-
NUMBER_403B = :"403b"
14-
NUMBER_403B_ROTH = :"403b_roth"
15-
NUMBER_457 = :"457"
16-
NUMBER_457_ROTH = :"457_roth"
10+
BENEFIT_TYPE_401K = :"401k"
11+
BENEFIT_TYPE_401K_ROTH = :"401k_roth"
12+
BENEFIT_TYPE_401K_LOAN = :"401k_loan"
13+
BENEFIT_TYPE_403B = :"403b"
14+
BENEFIT_TYPE_403B_ROTH = :"403b_roth"
15+
BENEFIT_TYPE_457 = :"457"
16+
BENEFIT_TYPE_457_ROTH = :"457_roth"
1717
S125_MEDICAL = :s125_medical
1818
S125_DENTAL = :s125_dental
1919
S125_VISION = :s125_vision

lib/finch_api/models/hris/pay_statement.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ module Type
210210
BONUS = :bonus
211211
COMMISSION = :commission
212212
TIPS = :tips
213-
NUMBER_1099 = :"1099"
213+
TYPE_1099 = :"1099"
214214
OTHER = :other
215215

216216
finalize!

lib/finch_api/models/sandbox/payment_create_params.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ module Type
263263
BONUS = :bonus
264264
COMMISSION = :commission
265265
TIPS = :tips
266-
NUMBER_1099 = :"1099"
266+
TYPE_1099 = :"1099"
267267
OTHER = :other
268268

269269
finalize!

rbi/lib/finch_api/models/hris/benefit_type.rbi

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@ module FinchAPI
1010
TaggedSymbol = T.type_alias { T.all(Symbol, FinchAPI::Models::HRIS::BenefitType) }
1111
OrSymbol = T.type_alias { T.any(Symbol, String, FinchAPI::Models::HRIS::BenefitType::TaggedSymbol) }
1212

13-
NUMBER_401K = T.let(:"401k", FinchAPI::Models::HRIS::BenefitType::TaggedSymbol)
14-
NUMBER_401K_ROTH = T.let(:"401k_roth", FinchAPI::Models::HRIS::BenefitType::TaggedSymbol)
15-
NUMBER_401K_LOAN = T.let(:"401k_loan", FinchAPI::Models::HRIS::BenefitType::TaggedSymbol)
16-
NUMBER_403B = T.let(:"403b", FinchAPI::Models::HRIS::BenefitType::TaggedSymbol)
17-
NUMBER_403B_ROTH = T.let(:"403b_roth", FinchAPI::Models::HRIS::BenefitType::TaggedSymbol)
18-
NUMBER_457 = T.let(:"457", FinchAPI::Models::HRIS::BenefitType::TaggedSymbol)
19-
NUMBER_457_ROTH = T.let(:"457_roth", FinchAPI::Models::HRIS::BenefitType::TaggedSymbol)
13+
BENEFIT_TYPE_401K = T.let(:"401k", FinchAPI::Models::HRIS::BenefitType::TaggedSymbol)
14+
BENEFIT_TYPE_401K_ROTH = T.let(:"401k_roth", FinchAPI::Models::HRIS::BenefitType::TaggedSymbol)
15+
BENEFIT_TYPE_401K_LOAN = T.let(:"401k_loan", FinchAPI::Models::HRIS::BenefitType::TaggedSymbol)
16+
BENEFIT_TYPE_403B = T.let(:"403b", FinchAPI::Models::HRIS::BenefitType::TaggedSymbol)
17+
BENEFIT_TYPE_403B_ROTH = T.let(:"403b_roth", FinchAPI::Models::HRIS::BenefitType::TaggedSymbol)
18+
BENEFIT_TYPE_457 = T.let(:"457", FinchAPI::Models::HRIS::BenefitType::TaggedSymbol)
19+
BENEFIT_TYPE_457_ROTH = T.let(:"457_roth", FinchAPI::Models::HRIS::BenefitType::TaggedSymbol)
2020
S125_MEDICAL = T.let(:s125_medical, FinchAPI::Models::HRIS::BenefitType::TaggedSymbol)
2121
S125_DENTAL = T.let(:s125_dental, FinchAPI::Models::HRIS::BenefitType::TaggedSymbol)
2222
S125_VISION = T.let(:s125_vision, FinchAPI::Models::HRIS::BenefitType::TaggedSymbol)

rbi/lib/finch_api/models/hris/pay_statement.rbi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ module FinchAPI
233233
BONUS = T.let(:bonus, FinchAPI::Models::HRIS::PayStatement::Earning::Type::TaggedSymbol)
234234
COMMISSION = T.let(:commission, FinchAPI::Models::HRIS::PayStatement::Earning::Type::TaggedSymbol)
235235
TIPS = T.let(:tips, FinchAPI::Models::HRIS::PayStatement::Earning::Type::TaggedSymbol)
236-
NUMBER_1099 = T.let(:"1099", FinchAPI::Models::HRIS::PayStatement::Earning::Type::TaggedSymbol)
236+
TYPE_1099 = T.let(:"1099", FinchAPI::Models::HRIS::PayStatement::Earning::Type::TaggedSymbol)
237237
OTHER = T.let(:other, FinchAPI::Models::HRIS::PayStatement::Earning::Type::TaggedSymbol)
238238

239239
sig { override.returns(T::Array[FinchAPI::Models::HRIS::PayStatement::Earning::Type::TaggedSymbol]) }

rbi/lib/finch_api/models/sandbox/payment_create_params.rbi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,7 @@ module FinchAPI
387387
)
388388
TIPS =
389389
T.let(:tips, FinchAPI::Models::Sandbox::PaymentCreateParams::PayStatement::Earning::Type::TaggedSymbol)
390-
NUMBER_1099 =
390+
TYPE_1099 =
391391
T.let(:"1099", FinchAPI::Models::Sandbox::PaymentCreateParams::PayStatement::Earning::Type::TaggedSymbol)
392392
OTHER =
393393
T.let(:other, FinchAPI::Models::Sandbox::PaymentCreateParams::PayStatement::Earning::Type::TaggedSymbol)

sig/finch_api/models/hris/benefit_type.rbs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,13 @@ module FinchAPI
2525
module BenefitType
2626
extend FinchAPI::Enum
2727

28-
NUMBER_401K: :"401k"
29-
NUMBER_401K_ROTH: :"401k_roth"
30-
NUMBER_401K_LOAN: :"401k_loan"
31-
NUMBER_403B: :"403b"
32-
NUMBER_403B_ROTH: :"403b_roth"
33-
NUMBER_457: :"457"
34-
NUMBER_457_ROTH: :"457_roth"
28+
BENEFIT_TYPE_401K: :"401k"
29+
BENEFIT_TYPE_401K_ROTH: :"401k_roth"
30+
BENEFIT_TYPE_401K_LOAN: :"401k_loan"
31+
BENEFIT_TYPE_403B: :"403b"
32+
BENEFIT_TYPE_403B_ROTH: :"403b_roth"
33+
BENEFIT_TYPE_457: :"457"
34+
BENEFIT_TYPE_457_ROTH: :"457_roth"
3535
S125_MEDICAL: :s125_medical
3636
S125_DENTAL: :s125_dental
3737
S125_VISION: :s125_vision

sig/finch_api/models/hris/pay_statement.rbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ module FinchAPI
147147
BONUS: :bonus
148148
COMMISSION: :commission
149149
TIPS: :tips
150-
NUMBER_1099: :"1099"
150+
TYPE_1099: :"1099"
151151
OTHER: :other
152152

153153
def self?.values: -> ::Array[FinchAPI::Models::HRIS::PayStatement::Earning::type_]

sig/finch_api/models/sandbox/payment_create_params.rbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ module FinchAPI
182182
BONUS: :bonus
183183
COMMISSION: :commission
184184
TIPS: :tips
185-
NUMBER_1099: :"1099"
185+
TYPE_1099: :"1099"
186186
OTHER: :other
187187

188188
def self?.values: -> ::Array[FinchAPI::Models::Sandbox::PaymentCreateParams::PayStatement::Earning::type_]

0 commit comments

Comments
 (0)