Skip to content

Commit 1927323

Browse files
fix: pages should be able to accept non-converter models (#65)
1 parent 797cdf7 commit 1927323

File tree

12 files changed

+29
-3
lines changed

12 files changed

+29
-3
lines changed

lib/finch-api/individuals_page.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ def initialize(client:, req:, headers:, page_data:)
4343

4444
case page_data
4545
in {individuals: Array | nil => individuals}
46-
@individuals = individuals&.map { model.coerce(_1) }
46+
@individuals = individuals&.map { FinchAPI::Converter.coerce(model, _1) }
4747
else
4848
end
4949

lib/finch-api/page.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ def initialize(client:, req:, headers:, page_data:)
4343

4444
case page_data
4545
in {data: Array | nil => data}
46-
@data = data&.map { model.coerce(_1) }
46+
@data = data&.map { FinchAPI::Converter.coerce(model, _1) }
4747
else
4848
end
4949

lib/finch-api/responses_page.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ def initialize(client:, req:, headers:, page_data:)
4040

4141
case page_data
4242
in {responses: Array | nil => responses}
43-
@responses = responses&.map { model.coerce(_1) }
43+
@responses = responses&.map { FinchAPI::Converter.coerce(model, _1) }
4444
else
4545
end
4646
end

test/finch-api/resources/hris/benefits/individuals_test.rb

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ def test_enroll_many
1111
end
1212

1313
row = response.to_enum.first
14+
return if row.nil?
15+
1416
assert_pattern do
1517
row => FinchAPI::Models::HRIS::Benefits::EnrolledIndividual
1618
end
@@ -47,6 +49,8 @@ def test_retrieve_many_benefits
4749
end
4850

4951
row = response.to_enum.first
52+
return if row.nil?
53+
5054
assert_pattern do
5155
row => FinchAPI::Models::HRIS::Benefits::IndividualBenefit
5256
end
@@ -68,6 +72,8 @@ def test_unenroll_many
6872
end
6973

7074
row = response.to_enum.first
75+
return if row.nil?
76+
7177
assert_pattern do
7278
row => FinchAPI::Models::HRIS::Benefits::UnenrolledIndividual
7379
end

test/finch-api/resources/hris/benefits_test.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,8 @@ def test_list
5656
end
5757

5858
row = response.to_enum.first
59+
return if row.nil?
60+
5961
assert_pattern do
6062
row => FinchAPI::Models::HRIS::CompanyBenefit
6163
end
@@ -78,6 +80,8 @@ def test_list_supported_benefits
7880
end
7981

8082
row = response.to_enum.first
83+
return if row.nil?
84+
8185
assert_pattern do
8286
row => FinchAPI::Models::HRIS::SupportedBenefit
8387
end

test/finch-api/resources/hris/directory_test.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ def test_list
1111
end
1212

1313
row = response.to_enum.first
14+
return if row.nil?
15+
1416
assert_pattern do
1517
row => FinchAPI::Models::HRIS::IndividualInDirectory
1618
end
@@ -36,6 +38,8 @@ def test_list_individuals
3638
end
3739

3840
row = response.to_enum.first
41+
return if row.nil?
42+
3943
assert_pattern do
4044
row => FinchAPI::Models::HRIS::IndividualInDirectory
4145
end

test/finch-api/resources/hris/employments_test.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ def test_retrieve_many_required_params
1111
end
1212

1313
row = response.to_enum.first
14+
return if row.nil?
15+
1416
assert_pattern do
1517
row => FinchAPI::Models::HRIS::EmploymentDataResponse
1618
end

test/finch-api/resources/hris/individuals_test.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ def test_retrieve_many
1111
end
1212

1313
row = response.to_enum.first
14+
return if row.nil?
15+
1416
assert_pattern do
1517
row => FinchAPI::Models::HRIS::IndividualResponse
1618
end

test/finch-api/resources/hris/pay_statements_test.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ def test_retrieve_many_required_params
1111
end
1212

1313
row = response.to_enum.first
14+
return if row.nil?
15+
1416
assert_pattern do
1517
row => FinchAPI::Models::HRIS::PayStatementResponse
1618
end

test/finch-api/resources/hris/payments_test.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ def test_list_required_params
1111
end
1212

1313
row = response.to_enum.first
14+
return if row.nil?
15+
1416
assert_pattern do
1517
row => FinchAPI::Models::HRIS::Payment
1618
end

0 commit comments

Comments
 (0)