Skip to content

Commit 1374a6e

Browse files
feat(api): api update (#69)
1 parent 7af6e91 commit 1374a6e

7 files changed

Lines changed: 19 additions & 30 deletions

File tree

.stats.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
configured_endpoints: 41
2-
openapi_spec_url: https://storage.googleapis.com/stainless-sdk-openapi-specs/finch%2Ffinch-f1779210fbedfc6099076412405288b489f727cbb0b3a85e7b7c12fabb37ef47.yml
2+
openapi_spec_url: https://storage.googleapis.com/stainless-sdk-openapi-specs/finch%2Ffinch-69819ddc6d03624ee8d880317fca03afab50a0a843218f1d9f14616e8a003dad.yml

lib/finch-api/models/hris/w42005.rb

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -59,15 +59,11 @@ class Data < FinchAPI::BaseModel
5959
# # @return [Symbol, FinchAPI::Models::HRIS::W42005::Data::Exemption]
6060
# attr_writer :exemption
6161

62-
# @!attribute [r] filing_status
62+
# @!attribute filing_status
6363
# The individual's filing status for tax purposes.
6464
#
6565
# @return [Symbol, FinchAPI::Models::HRIS::W42005::Data::FilingStatus, nil]
66-
optional :filing_status, enum: -> { FinchAPI::Models::HRIS::W42005::Data::FilingStatus }
67-
68-
# @!parse
69-
# # @return [Symbol, FinchAPI::Models::HRIS::W42005::Data::FilingStatus]
70-
# attr_writer :filing_status
66+
optional :filing_status, enum: -> { FinchAPI::Models::HRIS::W42005::Data::FilingStatus }, nil?: true
7167

7268
# @!attribute [r] individual_id
7369
# The unique identifier for the individual associated with this 2005 W4 form.
@@ -90,7 +86,7 @@ class Data < FinchAPI::BaseModel
9086
# #
9187
# # @param additional_withholding [Integer, nil]
9288
# # @param exemption [Symbol, FinchAPI::Models::HRIS::W42005::Data::Exemption]
93-
# # @param filing_status [Symbol, FinchAPI::Models::HRIS::W42005::Data::FilingStatus]
89+
# # @param filing_status [Symbol, FinchAPI::Models::HRIS::W42005::Data::FilingStatus, nil]
9490
# # @param individual_id [String]
9591
# # @param total_number_of_allowances [Integer, nil]
9692
# #

lib/finch-api/resources/hris/documents.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ module FinchAPI
44
module Resources
55
class HRIS
66
class Documents
7-
# **Beta:** This endpoint is in beta and may change.
8-
# Retrieve a list of company-wide documents.
7+
# **Beta:** This endpoint is in beta and may change. Retrieve a list of
8+
# company-wide documents.
99
#
1010
# @param params [FinchAPI::Models::HRIS::DocumentListParams, Hash{Symbol=>Object}] .
1111
#
@@ -33,8 +33,8 @@ def list(params = {})
3333
)
3434
end
3535

36-
# **Beta:** This endpoint is in beta and may change.
37-
# Retrieve details of a specific document by its ID.
36+
# **Beta:** This endpoint is in beta and may change. Retrieve details of a
37+
# specific document by its ID.
3838
#
3939
# @param document_id [String] The unique identifier of the document.
4040
#

rbi/lib/finch-api/models/hris/w42005.rbi

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -62,10 +62,7 @@ module FinchAPI
6262

6363
# The individual's filing status for tax purposes.
6464
sig { returns(T.nilable(FinchAPI::Models::HRIS::W42005::Data::FilingStatus::TaggedSymbol)) }
65-
attr_reader :filing_status
66-
67-
sig { params(filing_status: FinchAPI::Models::HRIS::W42005::Data::FilingStatus::OrSymbol).void }
68-
attr_writer :filing_status
65+
attr_accessor :filing_status
6966

7067
# The unique identifier for the individual associated with this 2005 W4 form.
7168
sig { returns(T.nilable(String)) }
@@ -83,7 +80,7 @@ module FinchAPI
8380
params(
8481
additional_withholding: T.nilable(Integer),
8582
exemption: FinchAPI::Models::HRIS::W42005::Data::Exemption::OrSymbol,
86-
filing_status: FinchAPI::Models::HRIS::W42005::Data::FilingStatus::OrSymbol,
83+
filing_status: T.nilable(FinchAPI::Models::HRIS::W42005::Data::FilingStatus::OrSymbol),
8784
individual_id: String,
8885
total_number_of_allowances: T.nilable(Integer)
8986
)
@@ -104,7 +101,7 @@ module FinchAPI
104101
{
105102
additional_withholding: T.nilable(Integer),
106103
exemption: FinchAPI::Models::HRIS::W42005::Data::Exemption::TaggedSymbol,
107-
filing_status: FinchAPI::Models::HRIS::W42005::Data::FilingStatus::TaggedSymbol,
104+
filing_status: T.nilable(FinchAPI::Models::HRIS::W42005::Data::FilingStatus::TaggedSymbol),
108105
individual_id: String,
109106
total_number_of_allowances: T.nilable(Integer)
110107
}

rbi/lib/finch-api/resources/hris/documents.rbi

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ module FinchAPI
44
module Resources
55
class HRIS
66
class Documents
7-
# **Beta:** This endpoint is in beta and may change.
8-
# Retrieve a list of company-wide documents.
7+
# **Beta:** This endpoint is in beta and may change. Retrieve a list of
8+
# company-wide documents.
99
sig do
1010
params(
1111
individual_ids: T::Array[String],
@@ -31,8 +31,8 @@ module FinchAPI
3131
)
3232
end
3333

34-
# **Beta:** This endpoint is in beta and may change.
35-
# Retrieve details of a specific document by its ID.
34+
# **Beta:** This endpoint is in beta and may change. Retrieve details of a
35+
# specific document by its ID.
3636
sig do
3737
params(
3838
document_id: String,

sig/finch-api/models/hris/w42005.rbs

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ module FinchAPI
3535
{
3636
additional_withholding: Integer?,
3737
exemption: FinchAPI::Models::HRIS::W42005::Data::exemption,
38-
filing_status: FinchAPI::Models::HRIS::W42005::Data::filing_status,
38+
filing_status: FinchAPI::Models::HRIS::W42005::Data::filing_status?,
3939
individual_id: String,
4040
total_number_of_allowances: Integer?
4141
}
@@ -49,11 +49,7 @@ module FinchAPI
4949
FinchAPI::Models::HRIS::W42005::Data::exemption
5050
) -> FinchAPI::Models::HRIS::W42005::Data::exemption
5151

52-
attr_reader filing_status: FinchAPI::Models::HRIS::W42005::Data::filing_status?
53-
54-
def filing_status=: (
55-
FinchAPI::Models::HRIS::W42005::Data::filing_status
56-
) -> FinchAPI::Models::HRIS::W42005::Data::filing_status
52+
attr_accessor filing_status: FinchAPI::Models::HRIS::W42005::Data::filing_status?
5753

5854
attr_reader individual_id: String?
5955

@@ -64,7 +60,7 @@ module FinchAPI
6460
def initialize: (
6561
?additional_withholding: Integer?,
6662
?exemption: FinchAPI::Models::HRIS::W42005::Data::exemption,
67-
?filing_status: FinchAPI::Models::HRIS::W42005::Data::filing_status,
63+
?filing_status: FinchAPI::Models::HRIS::W42005::Data::filing_status?,
6864
?individual_id: String,
6965
?total_number_of_allowances: Integer?
7066
) -> void

test/finch-api/resources/sandbox/company_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ def test_update_required_params
1212
entity: {},
1313
legal_name: "legal_name",
1414
locations: [{}],
15-
primary_email: "primary_email",
15+
primary_email: "dev@stainless.com",
1616
primary_phone_number: "primary_phone_number"
1717
)
1818

0 commit comments

Comments
 (0)