Skip to content

Commit 0b3397f

Browse files
chore: rename misleading variable (#8)
1 parent d36ae33 commit 0b3397f

File tree

16 files changed

+33
-33
lines changed

16 files changed

+33
-33
lines changed

lib/finch-api/base_client.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -447,7 +447,7 @@ def request(req)
447447
in { stream: Class => st }
448448
st.new(model: model, url: url, status: status, response: response, messages: decoded)
449449
in { page: Class => page }
450-
page.new(client: self, req: req, headers: response, unwrapped: decoded)
450+
page.new(client: self, req: req, headers: response, page_data: decoded)
451451
else
452452
unwrapped = FinchAPI::Util.dig(decoded, req[:unwrap])
453453
FinchAPI::Converter.coerce(model, unwrapped)

lib/finch-api/base_page.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ def to_enum = super(:auto_paging_each)
3333
# # @param client [FinchAPI::BaseClient]
3434
# # @param req [Hash{Symbol=>Object}]
3535
# # @param headers [Hash{String=>String}, Net::HTTPHeader]
36-
# # @param unwrapped [Object]
36+
# # @param page_data [Object]
3737
# #
38-
# def initialize(client:, req:, headers:, unwrapped:); end
38+
# def initialize(client:, req:, headers:, page_data:); end
3939
end
4040
end

lib/finch-api/individuals_page.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,20 +36,20 @@ class IndividualsPage
3636
# @param client [FinchAPI::BaseClient]
3737
# @param req [Hash{Symbol=>Object}]
3838
# @param headers [Hash{String=>String}, Net::HTTPHeader]
39-
# @param unwrapped [Hash{Symbol=>Object}]
39+
# @param page_data [Hash{Symbol=>Object}]
4040
#
41-
def initialize(client:, req:, headers:, unwrapped:)
41+
def initialize(client:, req:, headers:, page_data:)
4242
@client = client
4343
@req = req
4444
model = req.fetch(:model)
4545

46-
case unwrapped
46+
case page_data
4747
in {individuals: Array | nil => individuals}
4848
@individuals = individuals&.map { model.coerce(_1) }
4949
else
5050
end
5151

52-
case unwrapped
52+
case page_data
5353
in {paging: Hash | nil => paging}
5454
@paging = FinchAPI::Models::Paging.coerce(paging)
5555
else

lib/finch-api/page.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,20 +36,20 @@ class Page
3636
# @param client [FinchAPI::BaseClient]
3737
# @param req [Hash{Symbol=>Object}]
3838
# @param headers [Hash{String=>String}, Net::HTTPHeader]
39-
# @param unwrapped [Hash{Symbol=>Object}]
39+
# @param page_data [Hash{Symbol=>Object}]
4040
#
41-
def initialize(client:, req:, headers:, unwrapped:)
41+
def initialize(client:, req:, headers:, page_data:)
4242
@client = client
4343
@req = req
4444
model = req.fetch(:model)
4545

46-
case unwrapped
46+
case page_data
4747
in {data: Array | nil => data}
4848
@data = data&.map { model.coerce(_1) }
4949
else
5050
end
5151

52-
case unwrapped
52+
case page_data
5353
in {paging: Hash | nil => paging}
5454
@paging = FinchAPI::Models::Paging.coerce(paging)
5555
else

lib/finch-api/responses_page.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,14 +33,14 @@ class ResponsesPage
3333
# @param client [FinchAPI::BaseClient]
3434
# @param req [Hash{Symbol=>Object}]
3535
# @param headers [Hash{String=>String}, Net::HTTPHeader]
36-
# @param unwrapped [Array<Object>]
36+
# @param page_data [Array<Object>]
3737
#
38-
def initialize(client:, req:, headers:, unwrapped:)
38+
def initialize(client:, req:, headers:, page_data:)
3939
@client = client
4040
@req = req
4141
model = req.fetch(:model)
4242

43-
case unwrapped
43+
case page_data
4444
in {responses: Array | nil => responses}
4545
@responses = responses&.map { model.coerce(_1) }
4646
else

lib/finch-api/single_page.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,16 +30,16 @@ class SinglePage < ::Array
3030
# @param client [FinchAPI::BaseClient]
3131
# @param req [Hash{Symbol=>Object}]
3232
# @param headers [Hash{String=>String}, Net::HTTPHeader]
33-
# @param unwrapped [Array<Object>]
33+
# @param page_data [Array<Object>]
3434
#
35-
def initialize(client:, req:, headers:, unwrapped:)
35+
def initialize(client:, req:, headers:, page_data:)
3636
@client = client
3737
@req = req
3838
model = req.fetch(:model)
3939

40-
case unwrapped
40+
case page_data
4141
in Array
42-
super(unwrapped&.map { model.coerce(_1) })
42+
super(page_data&.map { model.coerce(_1) })
4343
else
4444
super([])
4545
end

rbi/lib/finch-api/base_page.rbi

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@ module FinchAPI
2929
client: FinchAPI::BaseClient,
3030
req: FinchAPI::BaseClient::RequestComponentsShape,
3131
headers: T.any(T::Hash[String, String], Net::HTTPHeader),
32-
unwrapped: T.anything
32+
page_data: T.anything
3333
)
3434
.void
3535
end
36-
def initialize(client:, req:, headers:, unwrapped:)
36+
def initialize(client:, req:, headers:, page_data:)
3737
end
3838
end
3939
end

rbi/lib/finch-api/individuals_page.rbi

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,11 @@ module FinchAPI
2727
client: FinchAPI::BaseClient,
2828
req: FinchAPI::BaseClient::RequestComponentsShape,
2929
headers: T.any(T::Hash[String, String], Net::HTTPHeader),
30-
unwrapped: T::Hash[Symbol, T.anything]
30+
page_data: T::Hash[Symbol, T.anything]
3131
)
3232
.void
3333
end
34-
def initialize(client:, req:, headers:, unwrapped:)
34+
def initialize(client:, req:, headers:, page_data:)
3535
end
3636
end
3737
end

rbi/lib/finch-api/page.rbi

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,11 @@ module FinchAPI
2727
client: FinchAPI::BaseClient,
2828
req: FinchAPI::BaseClient::RequestComponentsShape,
2929
headers: T.any(T::Hash[String, String], Net::HTTPHeader),
30-
unwrapped: T::Hash[Symbol, T.anything]
30+
page_data: T::Hash[Symbol, T.anything]
3131
)
3232
.void
3333
end
34-
def initialize(client:, req:, headers:, unwrapped:)
34+
def initialize(client:, req:, headers:, page_data:)
3535
end
3636
end
3737
end

rbi/lib/finch-api/responses_page.rbi

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,11 @@ module FinchAPI
1919
client: FinchAPI::BaseClient,
2020
req: FinchAPI::BaseClient::RequestComponentsShape,
2121
headers: T.any(T::Hash[String, String], Net::HTTPHeader),
22-
unwrapped: T::Array[T.anything]
22+
page_data: T::Array[T.anything]
2323
)
2424
.void
2525
end
26-
def initialize(client:, req:, headers:, unwrapped:)
26+
def initialize(client:, req:, headers:, page_data:)
2727
end
2828
end
2929
end

0 commit comments

Comments
 (0)