Skip to content

Commit 9b52734

Browse files
chore(internal): support x-stainless-mcp-client-envs header in MCP servers
1 parent 02fd3db commit 9b52734

4 files changed

Lines changed: 45 additions & 17 deletions

File tree

packages/mcp-server/src/code-tool.ts

Lines changed: 27 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -145,18 +145,22 @@ const remoteStainlessHandler = async ({
145145

146146
const codeModeEndpoint = readEnv('CODE_MODE_ENDPOINT_URL') ?? 'https://api.stainless.com/api/ai/code-tool';
147147

148+
const localClientEnvs = {
149+
FINCH_CLIENT_ID: readEnv('FINCH_CLIENT_ID') ?? client.clientID ?? undefined,
150+
FINCH_CLIENT_SECRET: readEnv('FINCH_CLIENT_SECRET') ?? client.clientSecret ?? undefined,
151+
FINCH_WEBHOOK_SECRET: readEnv('FINCH_WEBHOOK_SECRET') ?? client.webhookSecret ?? undefined,
152+
FINCH_BASE_URL: readEnv('FINCH_BASE_URL') ?? client.baseURL ?? undefined,
153+
};
154+
// Merge any upstream client envs from the request header, with upstream values taking precedence.
155+
const mergedClientEnvs = { ...localClientEnvs, ...reqContext.upstreamClientEnvs };
156+
148157
// Setting a Stainless API key authenticates requests to the code tool endpoint.
149158
const res = await fetch(codeModeEndpoint, {
150159
method: 'POST',
151160
headers: {
152161
...(reqContext.stainlessApiKey && { Authorization: reqContext.stainlessApiKey }),
153162
'Content-Type': 'application/json',
154-
'x-stainless-mcp-client-envs': JSON.stringify({
155-
FINCH_CLIENT_ID: readEnv('FINCH_CLIENT_ID') ?? client.clientID ?? undefined,
156-
FINCH_CLIENT_SECRET: readEnv('FINCH_CLIENT_SECRET') ?? client.clientSecret ?? undefined,
157-
FINCH_WEBHOOK_SECRET: readEnv('FINCH_WEBHOOK_SECRET') ?? client.webhookSecret ?? undefined,
158-
FINCH_BASE_URL: readEnv('FINCH_BASE_URL') ?? client.baseURL ?? undefined,
159-
}),
163+
'x-stainless-mcp-client-envs': JSON.stringify(mergedClientEnvs),
160164
},
161165
body: JSON.stringify({
162166
project_name: 'finch',
@@ -267,6 +271,9 @@ const localDenoHandler = async ({
267271
printOutput: true,
268272
spawnOptions: {
269273
cwd: path.dirname(workerPath),
274+
// Merge any upstream client envs into the Deno subprocess environment,
275+
// with the upstream env vars taking precedence.
276+
env: { ...process.env, ...reqContext.upstreamClientEnvs },
270277
},
271278
});
272279

@@ -276,16 +283,20 @@ const localDenoHandler = async ({
276283
reject(new Error(`Worker exited with code ${exitCode}`));
277284
});
278285

279-
const opts: ClientOptions = {
280-
baseURL: client.baseURL,
281-
accessToken: client.accessToken,
282-
clientID: client.clientID,
283-
clientSecret: client.clientSecret,
284-
webhookSecret: client.webhookSecret,
285-
defaultHeaders: {
286-
'X-Stainless-MCP': 'true',
287-
},
288-
};
286+
// Strip null/undefined values so that the worker SDK client can fall back to
287+
// reading from environment variables (including any upstreamClientEnvs).
288+
const opts: ClientOptions = Object.fromEntries(
289+
Object.entries({
290+
baseURL: client.baseURL,
291+
accessToken: client.accessToken,
292+
clientID: client.clientID,
293+
clientSecret: client.clientSecret,
294+
webhookSecret: client.webhookSecret,
295+
defaultHeaders: {
296+
'X-Stainless-MCP': 'true',
297+
},
298+
}).filter(([_, v]) => v != null),
299+
) as ClientOptions;
289300

290301
const req = worker.request(
291302
'http://localhost',

packages/mcp-server/src/http.ts

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,19 @@ const newServer = async ({
2727

2828
const authOptions = parseClientAuthHeaders(req, false);
2929

30+
let upstreamClientEnvs: Record<string, string> | undefined;
31+
const clientEnvsHeader = req.headers['x-stainless-mcp-client-envs'];
32+
if (typeof clientEnvsHeader === 'string') {
33+
try {
34+
const parsed = JSON.parse(clientEnvsHeader);
35+
if (parsed && typeof parsed === 'object' && !Array.isArray(parsed)) {
36+
upstreamClientEnvs = parsed;
37+
}
38+
} catch {
39+
// Ignore malformed header
40+
}
41+
}
42+
3043
await initMcpServer({
3144
server: server,
3245
mcpOptions: mcpOptions,
@@ -35,6 +48,7 @@ const newServer = async ({
3548
...authOptions,
3649
},
3750
stainlessApiKey: stainlessApiKey,
51+
upstreamClientEnvs,
3852
});
3953

4054
return server;
@@ -72,7 +86,7 @@ const del = async (req: express.Request, res: express.Response) => {
7286
};
7387

7488
const redactHeaders = (headers: Record<string, any>) => {
75-
const hiddenHeaders = /auth|cookie|key|token/i;
89+
const hiddenHeaders = /auth|cookie|key|token|x-stainless-mcp-client-envs/i;
7690
const filtered = { ...headers };
7791
Object.keys(filtered).forEach((key) => {
7892
if (hiddenHeaders.test(key)) {

packages/mcp-server/src/server.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ export async function initMcpServer(params: {
3838
clientOptions?: ClientOptions;
3939
mcpOptions?: McpOptions;
4040
stainlessApiKey?: string | undefined;
41+
upstreamClientEnvs?: Record<string, string> | undefined;
4142
}) {
4243
const server = params.server instanceof McpServer ? params.server.server : params.server;
4344

@@ -120,6 +121,7 @@ export async function initMcpServer(params: {
120121
reqContext: {
121122
client,
122123
stainlessApiKey: params.stainlessApiKey ?? params.mcpOptions?.stainlessApiKey,
124+
upstreamClientEnvs: params.upstreamClientEnvs,
123125
},
124126
args,
125127
});

packages/mcp-server/src/types.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ export type ToolCallResult = {
4545
export type McpRequestContext = {
4646
client: Finch;
4747
stainlessApiKey?: string | undefined;
48+
upstreamClientEnvs?: Record<string, string> | undefined;
4849
};
4950

5051
export type HandlerFunction = ({

0 commit comments

Comments
 (0)