Skip to content

test: Add invariant tests for SumTree structure in PDPVerifier #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hany-Almnaem wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test: Add invariant tests for SumTree structure in PDPVerifier #166

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cff6b86
test: Add invariant tests for SumTree (basic and advanced coverage)
Hany-Almnaem May 26, 2025
3fbdc47
test: simplify sumtree invariant tests
Hany-Almnaem Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 65 additions & 0 deletions test/PDPVerifier.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1426,6 +1426,71 @@ contract SumTreeAddTest is MockFVMTest, PieceHelper {
assertEq(pdpVerifier.getDataSetLeafCount(testSetId), 820, "Incorrect final data set leaf count");
}

function assertSumTreeInvariant(uint256 setId) internal view {
uint256 nextPieceId = pdpVerifier.getNextPieceId(setId);
for (uint256 index = 0; index < nextPieceId; index++) {
uint256 height = pdpVerifier.getTestHeightFromIndex(index);
uint256 range = 1 << height;

require(index + 1 >= range, "SumTree range underflow");

uint256 expectedSum = 0;
for (uint256 j = index + 1 - range; j <= index; j++) {
Copy link
Contributor

@ZenGround0 ZenGround0 Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct ✅

expectedSum += pdpVerifier.getPieceLeafCount(setId, j);
}

uint256 actualSum = pdpVerifier.getSumTreeCounts(setId, index);
assertEq(
actualSum,
expectedSum,
string(abi.encodePacked("SumTree invariant failed at index ", vm.toString(index)))
);
}
}

function testSumTreeInvariantAddsAndRemovals() public {
uint256 numRounds = 5;
uint256 piecesPerRound = 8;

for (uint256 round = 0; round < numRounds; round++) {
Cids.Cid[] memory pieces = new Cids.Cid[](piecesPerRound);
for (uint256 i = 0; i < piecesPerRound; i++) {
uint256 size = ((round + 1) * 100) + (i * 10) + (i % 3);
pieces[i] = makeSamplePiece(size);
}
pdpVerifier.addPieces(testSetId, address(0), pieces, empty);

uint256[] memory toRemove = new uint256[](piecesPerRound / 2);
for (uint256 i = 0; i < toRemove.length; i++) {
toRemove[i] = round * piecesPerRound + (i * 2);
}
pdpVerifier.schedulePieceDeletions(testSetId, toRemove, empty);

pdpVerifier.nextProvingPeriod(testSetId, vm.getBlockNumber() + CHALLENGE_FINALITY_DELAY, empty);

assertSumTreeInvariant(testSetId);
}
}

function testSumTreeAlternatingPattern() public {
uint256 numOperations = 10;

for (uint256 i = 0; i < numOperations; i++) {
Cids.Cid[] memory piece = new Cids.Cid[](1);
piece[0] = makeSamplePiece((i + 1) * 10);
pdpVerifier.addPieces(testSetId, address(0), piece, empty);

if (i > 0 && i % 2 == 1) {
uint256[] memory toRemove = new uint256[](1);
toRemove[0] = i - 1;
pdpVerifier.schedulePieceDeletions(testSetId, toRemove, empty);
}

pdpVerifier.nextProvingPeriod(testSetId, vm.getBlockNumber() + CHALLENGE_FINALITY_DELAY, empty);
assertSumTreeInvariant(testSetId);
}
}

function testFindPieceId() public {
setUpTestingArray();

Expand Down