-
Notifications
You must be signed in to change notification settings - Fork 13
Open
Milestone
Description
From audit:
In _settleSegmentGross (
) you check require( payer.lockupCurrent >= grossSettledAmount while it should be require( payer.lockupCurrent >= requiredLockup because requiredLockup is subtracted from lockupCurrentfilecoin-pay/src/FilecoinPayV1.sol
Lines 1467 to 1470 in 1132b52
require( payer.lockupCurrent >= grossSettledAmount, Errors.InsufficientLockupForSettlement(rail.token, rail.from, payer.lockupCurrent, grossSettledAmount) );
Because grossSettledAmount is always >= requiredLockup the existing check should be safe. But the suggested modification is clearer.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels