From 8e70548a122a75e860f9b31f445a44ac9dafa4bf Mon Sep 17 00:00:00 2001 From: hatz Date: Tue, 10 Sep 2024 15:23:40 -0500 Subject: [PATCH] Migrate to shared-actions `v2` MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit > [!IMPORTANT] > **Please thoroughly review this PR before approving and merging** > This migration is complicated and may require some manual changes. Below we will call out breaking changes and other important notes. This PR moves all workflows to the new shared-actions v2. Please check out the following docs for more information on this migration: - [Migration Guide](https://docs.devops.figure.com/shared-actions/v2-migration-guide) - [Migration Changes](https://docs.devops.figure.com/shared-actions/v2-migration-changes) Please reach out to [#github-actions-help](https://figure-group.slack.com/archives/C044W9BRAVD) with any and all questions, someone from devops or core tech will be able to help. --- ### Notes - Once you've merged in this PR and are running `v2` actions it is worth watching your workflows for warnings about inputs that are no longer used. We are able to handle a lot of replacements automatically, but we err on the side of caution to avoid breaking other github actions that we don't own. These warnings won't ever break your builds, but it is good practice to keep them clean. - Some other common upgrades are also done in this PR, like updating other `actions/` to their latest versions. 🤖🪄 This PR was automatically created by a magic script. --- .github/workflows/build.yaml | 4 ++-- .github/workflows/publish.yaml | 5 ++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index ab9146a..409c36d 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -10,10 +10,10 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout Code - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Setup JDK 17 - uses: actions/setup-java@v3 + uses: actions/setup-java@v4 with: java-version: 17 distribution: zulu diff --git a/.github/workflows/publish.yaml b/.github/workflows/publish.yaml index ded3c75..1dd2460 100644 --- a/.github/workflows/publish.yaml +++ b/.github/workflows/publish.yaml @@ -16,7 +16,7 @@ jobs: ACTIONS_ALLOW_UNSECURE_COMMANDS: true steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Get Version run: | @@ -30,7 +30,7 @@ jobs: echo "::set-env name=RELEASE_VERSION::$RELEASE_VERSION" - name: Set up JDK 17 - uses: actions/setup-java@v3 + uses: actions/setup-java@v4 with: java-version: 17 distribution: zulu @@ -60,4 +60,3 @@ jobs: -Psigning.keyId="${{ secrets.OSSRH_GPG_SECRET_KEY_ID }}" -Psigning.password="${{ secrets.OSSRH_GPG_SECRET_KEY_PASSWORD }}" -Psigning.secretKeyRingFile=$GITHUB_WORKSPACE/release.gpg \ --info -