Skip to content

fix: resolve SonarQube code quality issues #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Fauxirius wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve SonarQube code quality issues #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion JU4/src/main/java/com/javatechie/pm/api/service/OrderService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package com.javatechie.pm.api.service;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.http.HttpStatus;
import org.springframework.stereotype.Service;

Expand All @@ -10,6 +12,8 @@
@Service
public class OrderService {

private static final Logger logger = LoggerFactory.getLogger(OrderService.class);

private final NotificationUtil notificationUtil;

public OrderService(NotificationUtil notificationUtil) {
Expand All @@ -25,7 +29,7 @@ public OrderResponse checkoutOrder(OrderRequest order) {
}

private int addDiscount(OrderRequest order) {
System.out.println("called...");
logger.info("called...");
int price = order.getPrice();
int discountAMount = 0;
if (order.isDiscountable()) {
Expand Down