Skip to content

Checking for cookie before setting the cookie? #32

@m4v15

Description

@m4v15

In the home handler here: https://github.com/FACK1/Mylibrary/blob/master/src/server/homeHandler.js#L14

You are checking for a cookie, but you haven't set it in the login handler yet? I would probably set and check the cookie in the same PR - it's fine to split them out, but then it would make sense for the next immediate pull request to be setting the cookie!

you should sign the jwt and set the cookie here:

https://github.com/FACK1/Mylibrary/blob/master/src/server/handler.js#L84

Otherwise this is kind of pointless...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions