Skip to content

Fix chat responses failing due to null deserialization and tool call errors #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Fix chat responses failing due to null deserialization and tool call errors #10

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
43b601a
Initial plan
Copilot Dec 27, 2025
d18333c
Fix chat feature not receiving responses when tool calls fail
Copilot Dec 27, 2025
ed28a99
Improve fallback comment clarity based on code review
Copilot Dec 27, 2025
288d4d5
Add null check for deserialized response to prevent NullReferenceExce…
Copilot Dec 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/AI/OllamaClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,13 @@ public async Task<string> ChatAsync(string message, CancellationToken cancellati
var responseContent = await response.Content.ReadAsStringAsync();
var result = JsonConvert.DeserializeObject<OllamaChatResponse>(responseContent);

// Check if deserialization was successful
if (result == null)
{
System.Diagnostics.Debug.WriteLine("Ollama chat error: Failed to deserialize response");
return null;
}

// Track token usage
LastPromptTokens = result.PromptEvalCount;
LastCompletionTokens = result.EvalCount;
Expand Down Expand Up @@ -436,7 +443,10 @@ public async Task<string> ChatAsync(string message, CancellationToken cancellati
}
}
}
else if (result?.Message?.Content != null)

// Fallback: If tool calls failed, returned no content, or follow-up request failed,
// use the original response content if available
if (result?.Message?.Content != null)
{
string cleanedResponse = CleanResponse(result.Message.Content);

Expand All @@ -446,6 +456,9 @@ public async Task<string> ChatAsync(string message, CancellationToken cancellati

return cleanedResponse;
}

// No content available in response
System.Diagnostics.Debug.WriteLine("Ollama chat: Response received but no content available");
}
else
{
Expand Down
Loading