[HOLD for payment 2024-09-10] [$1000] Upgrade to RN 0.75

[roryabraham]

slack context: https://expensify.slack.com/archives/C02NK2DQWUX/p1709024519896479

Problem

There are some new arch problems that should be fixed in RN 0.74+. So far that's the only thing I'm aware of in 0.74+ that we'll need, but it takes a long time to upgrade. It's not necessarily a blocker but unless we upgrade we'll have to use patches.

Solution

Let's get the ball rolling on the RN 0.74 upgrade. If there are issues in the RC we should report them to Meta.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021833172516619025999
• Upwork Job ID: 1833172516619025999
• Last Price Increase: 2024-09-09

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @dylanexpensify

[MrRefactor]

Hey, I would like to work on this issue!

[roryabraham]

@MrRefactor I'd strongly recommend you to try https://github.com/infinitered/flame. There's a talk from Jamon it's creator here. I hope it will help streamline the upgrade process for you.

[MrRefactor]

@roryabraham Sure! I will get gpt-4 and try upgrading with that tool!

[roryabraham]

wrote some best practices on RN upgrades earlier today:

1. Look at the release notes to understand what changed.
2. Look at any patches that we've got, find the upstream PR associated with the patch by looking at the PR that introduced the patch: there should be a link to an upstream PR for the patch in the PR description. Evaluate if that patch is still needed or can be removed. If it's still needed, coordinate with the author of the patch to figure out how it needs to be applied to the new version. Have them update their upstream PR if needed. Also consider alternatives if Meta doesn't seem to be actively reviewing the PR. Open a conversation in slack if you're not sure.
3. If there are any deprecations, investigate what's needed to remove our usage of deprecated code. It doesn't necessarily need to be a blocker, but we want to try to remove uses of deprecated APIs ASAP.
4. Use flame, an AI-powered CLI made specifically for upgrading React Native. It uses react-native-upgrade-helper under the hood and leverages GPT-4 to apply the diff more intelligently. Very cool tool, you can see a demo here.
5. Use 2 C+ testers instead of just 1
6. Create an AdHoc build and have Applause run a full regression suite
7. Create a GitHub Project for the upgrade so that if any issues are identified, they can be added to the project and tracked effectively, rather than just being comments in the PR. That way we can track what issues need to be resolved and re-tested on staging.

[MrRefactor]

Update:

1. Tried upgrading with flame-ai but as its still in experimental stage its not really working as expected with 0.74, opened an issue with one of the problems connected with that.
2. Manually applied changes from upgrade-helper - I will create draft PR and will be adding any progress there
3. I will go through all of the patches and list them to make sure if upgrade of rn version is affecting those

[MrRefactor]

Update:

1. Working on rc-2 as it was released couple days ago
2. Working on resolving issues with dependencies, trying to apply temporary workaround to get app running on android & ios
3. Resolving issues with react-native-quick-sqlite connected to wrong compilation of Folly on iOS
4. Resolving issues with react-native-live-markdown on android
5. Checking compatibility in android dependencies connected to gradle versioning

CC: @roryabraham @mountiny

[MrRefactor]

Update:

Created an issue in react-native-quick-sqlite as the same error is visible while building with fresh rn app. In meantime working on a fix for that problem.

[roryabraham]

Created an https://github.com/margelo/react-native-quick-sqlite/issues/37 in react-native-quick-sqlite as the same error is visible while building with fresh rn app. In meantime working on a fix for that problem.

Posted in the Margelo room