Skip to content

feat(daemoneye-agent): implement agent loading state, heartbeat detection, and recovery #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
unclesp1d3r merged 9 commits into from
Feb 3, 2026
+3,438 −17
Merged

feat(daemoneye-agent): implement agent loading state, heartbeat detection, and recovery #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
590310a
Mark Ticket 3 as complete in procmond spec
unclesp1d3r Feb 2, 2026
5d0fdb5
docs(agents): add Clippy lint guidance for map_err_ignore and as_conv…
unclesp1d3r Feb 2, 2026
1391f44
feat(daemoneye-agent): implement agent loading state and collector co…
unclesp1d3r Feb 2, 2026
2830732
feat(daemoneye-agent): implement heartbeat detection and escalating r…
unclesp1d3r Feb 2, 2026
6472d82
fix(daemoneye-agent): address CodeRabbit review findings
unclesp1d3r Feb 3, 2026
5e59c8f
fix(daemoneye-agent): add clippy lint allows for test modules
unclesp1d3r Feb 3, 2026
f2f0aca
fix(daemoneye-agent): address Copilot PR review comments
unclesp1d3r Feb 3, 2026
38d7190
fix(daemoneye-agent): make validation tests cross-platform
unclesp1d3r Feb 3, 2026
37c1838
chore: adjust codecov thresholds to realistic targets
unclesp1d3r Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,9 @@ flowchart LR
- **Linting**: `cargo clippy -- -D warnings` (zero warnings)
- **Format args**: Use `{variable}` inlined syntax in `format!`/`anyhow!` macros (`clippy::uninlined_format_args`)
- **If-else ordering**: Clippy prefers `==` checks first in if-else (`clippy::unnecessary_negation`)
- **map_err_ignore**: Name ignored variables in closures (`|_elapsed|` not `|_|`)
- **as_conversions**: Add `#[allow(clippy::as_conversions)]` with safety comment for intentional casts
- **Async in tracing macros**: Never `.await` inside `info!`/`debug!`/`warn!`/`error!` - causes `future_not_send`. Extract value first.
- **Safety**: `unsafe_code = "forbid"` at workspace level
- **Formatting**: `rustfmt` with 119 char line length
- **Rustdoc**: Escape brackets in paths like `/proc/\[pid\]/stat` to avoid broken link warnings
Expand All @@ -176,6 +179,8 @@ flowchart LR
5. No new `unsafe` without approval
6. Benchmarks within acceptable ranges

**Gotchas**: Pre-commit runs `cargo fmt` which modifies files. If unstaged changes exist, commit may fail with "Stashed changes conflicted". Run `cargo fmt --all` before staging or reset unrelated unstaged files.

---

## Security Model
Expand Down Expand Up @@ -330,6 +335,7 @@ pub trait AlertSink: Send + Sync {
- **Property**: proptest for edge cases
- **Fuzz**: Security-critical components
- **Snapshot**: insta for CLI output
- **Cross-crate traits**: Import traits for method access (e.g., `use daemoneye_eventbus::rpc::RegistrationProvider;`)

### Test Environment

Expand Down
8 changes: 4 additions & 4 deletions codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@ coverage:
status:
project:
default:
target: 85%
threshold: 2%
target: 80%
threshold: 5%
patch:
default:
target: 90%
threshold: 5%
target: 70%
threshold: 10%
ignore:
- "tests/**/*"
- "benches/**/*"
Expand Down
Loading
Loading