-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat(procmond): implement WAL and EventBus connector integration #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
unclesp1d3r
merged 30 commits into
main
from
39-featprocmond-implement-cross-platform-process-enumeration-with-enhanced-metadata-collection
Jan 30, 2026
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
d08afcb
feat: cross-platform procmond + WAL (#39)
unclesp1d3r 9c2ece5
Refine Claude review command guidelines
unclesp1d3r 67fe090
Update language server list and project name
unclesp1d3r 477537e
Add procmond implementation specs and planning docs
unclesp1d3r 6824aca
feat(config): add tools configuration for build and documentation
unclesp1d3r c7d03e1
feat(procmond): implement comprehensive ticket index for procmond epic
unclesp1d3r 6cca7b4
feat(procmond): implement WAL and EventBus connector integration
unclesp1d3r b58afaf
feat(config): enhance mise.toml with additional tool configurations
unclesp1d3r aaf5a66
ci: update actions/checkout to v6 and rust-toolchain to 1.91.0
unclesp1d3r 7273b07
chore(ci): update actions/checkout to v6 and jdx/mise-action for work…
unclesp1d3r d1993a4
feat(procmond): implement agent loading state and heartbeat detection
unclesp1d3r d5485b8
refactor(procmond): migrate from bincode to postcard serialization
unclesp1d3r e0f0316
refactor: address qlty and coderabbit review comments
unclesp1d3r e36512f
fix: address clippy lints in linux_collector.rs
unclesp1d3r 23ae9e4
fix: address remaining clippy lints in linux_collector.rs
unclesp1d3r 77b22e4
fix: simplify conditionals in linux_collector.rs
unclesp1d3r f1d0940
fix: address additional clippy lints in linux_collector.rs
unclesp1d3r 099e6b1
fix(procmond): address additional clippy lints for Linux collector
unclesp1d3r dc00ea8
fix(procmond): add type annotation to processed_count variable
unclesp1d3r 5883a65
fix(procmond): address three more clippy lints
unclesp1d3r 8015809
fix(procmond): fix test clippy warnings
unclesp1d3r aff40dc
fix(procmond): expand test clippy allow lists
unclesp1d3r 62c59d6
ci: disable ARM runner in test-cross-platform matrix
unclesp1d3r 5972c40
fix: resolve Windows build errors in test files
unclesp1d3r 003b72d
refactor: address qltysh code quality comments
unclesp1d3r a8d5187
fix(procmond): implement start_time parsing and improve type safety
unclesp1d3r 722a621
fix(procmond): address code review findings
unclesp1d3r 3b98d3a
chore: add coderabbit configuration
unclesp1d3r 61b4ebe
docs: escape brackets in rustdoc comment to fix broken intra-doc link
unclesp1d3r 902bf00
fix: resolve clippy warnings in linux_collector
unclesp1d3r File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| Analyze this codebase's architecture: | ||
| # Analyze this codebase's architecture | ||
|
|
||
| 1. Evaluate the overall structure and patterns | ||
| 2. Identify potential architectural issues | ||
| 3. Suggest improvements for scalability | ||
| 4. Note areas that follow best practices | ||
|
|
||
| Focus on maintainability and modularity. | ||
| Focus on maintainability and modularity. Consider the simplest approach that will work for the long term. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,10 @@ | ||
| Analyze the project dependencies: | ||
| # Analyze the project dependencies | ||
|
|
||
| 1. Identify outdated packages | ||
| 2. Check for security vulnerabilities | ||
| 3. Suggest alternative packages | ||
| 4. Review dependency usage patterns | ||
| 5. Make the refactoring changes | ||
| 6. Summarize what you reviewed and why | ||
|
|
||
| Include specific upgrade recommendations. | ||
| Always finish by running `just ci-check` and ensuring that all checks and tests remain green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,10 @@ | ||
| Review the codebase for performance: | ||
| # Review the codebase for performance | ||
|
|
||
| 1. Identify performance bottlenecks | ||
| 2. Check resource utilization | ||
| 3. Review algorithmic efficiency | ||
| 4. Assess caching strategies | ||
| 5. Make the refactoring changes | ||
| 6. Summarize what you reviewed and why | ||
|
|
||
| Include specific optimization recommendations. | ||
| Always finish by running `just ci-check` and ensuring that all checks and tests remain green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,36 +1,36 @@ | ||
| CODE SIMPLIFICATION REVIEW | ||
| # Code Simplification Review | ||
|
|
||
| Start by examining the uncommitted changes (or the changes in the current branch compared with main branch if there are no uncommitted changes) in the current codebase. | ||
|
|
||
| ANALYSIS STEPS: | ||
| ## ANALYSIS STEPS | ||
|
|
||
| 1. Identify what files have been modified or added | ||
| 2. Review the actual code changes | ||
| 3. Apply simplification principles below | ||
| 4. Refactor directly, then show what you changed | ||
|
|
||
| SIMPLIFICATION PRINCIPLES: | ||
| ## SIMPLIFICATION PRINCIPLES | ||
|
|
||
| Complexity Reduction: | ||
| ### Complexity Reduction | ||
|
|
||
| - Remove abstraction layers that don't provide clear value | ||
| - Replace complex patterns with straightforward implementations | ||
| - Use language idioms over custom abstractions | ||
| - If a simple function/lambda works, use it—don't create classes | ||
|
|
||
| Test Proportionality: | ||
| ### Test Proportionality | ||
|
|
||
| - Keep only tests for critical functionality and real edge cases | ||
| - Delete tests for trivial operations, framework behavior, or hypothetical scenarios | ||
| - For small projects: aim for \<10 meaningful tests per feature | ||
| - Test code should be shorter than implementation | ||
|
|
||
| Idiomatic Code: | ||
| ### Idiomatic Code | ||
|
|
||
| - Use conventional patterns for the language | ||
| - Prioritize readability and maintainability | ||
| - Apply the principle of least surprise | ||
|
|
||
| Ask yourself: "What's the simplest version that actually works reliably?" | ||
| ## Ask yourself: "What's the simplest version that actually works reliably?" | ||
|
|
||
| Make the refactoring changes, then summarize what you simplified and why. Always finish by running `just ci-check` and ensuring that all checks and tests remain green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # Review the test coverage | ||
|
|
||
| 1. Identify untested components | ||
| 2. Suggest additional test cases | ||
| 3. Review test quality | ||
| 4. Recommend testing strategies | ||
| 5. Make the refactoring changes | ||
| 6. Summarize what you reviewed and why | ||
| 7. Always finish by running `just ci-check` and ensuring that all checks and tests remain green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
qualityjob sets up Rust twice (dtolnay/rust-toolchain@...and thenjdx/mise-actionwhich also installs the toolchain viamise.toml). This can add time and create ambiguity about whichcargo/toolchain is actually being used in later steps. Consider standardizing on a single toolchain installation path (preferably just mise here) and remove the redundant setup.