Исправлена ошибка при регистрации обработчика на второе событие у одного источника

[sfaqer]

Исправлена ошибка при регистрации обработчика на второе событие у одного источника

Summary by CodeRabbit

• New Features

  • Added a new test procedure to verify event source functionality with multiple events.

• Bug Fixes

  • Improved event handler registration logic to prevent unnecessary instantiation and enhance error handling.

[coderabbitai]

Walkthrough

The pull request introduces enhancements to the event handling logic in the DefaultEventProcessor class, focusing on the AddHandler, RemoveHandler, and HandleEvent methods. It implements checks to prevent unnecessary instantiation of HandlersList and improves error handling. Additionally, a new test procedure is added in tests/events.os to verify that an event source can manage multiple events effectively without modifying existing code.

Changes

File	Change Summary
src/ScriptEngine.HostedScript/DefaultEventProcessor.cs	Improved event handler management with checks in AddHandler, RemoveHandler, and HandleEvent methods to prevent redundant operations and enhance error handling.
tests/events.os	Added new exported test procedure ТестДолжен_ПроверитьЧтоУИсточникаМожетБытьНесколькоСобытий() to test multiple event handling capabilities.

Sequence Diagram

sequenceDiagram
    participant EventSource
    participant EventProcessor
    participant Handler1
    participant Handler2

    EventSource->>EventProcessor: Add Handler for Event1
    EventProcessor-->>EventSource: Confirm Handler1 registered
    EventSource->>EventProcessor: Add Handler for Event2
    EventProcessor-->>EventSource: Confirm Handler2 registered
    
    EventSource->>EventProcessor: Trigger Event1
    EventProcessor->>Handler1: Invoke
    
    EventSource->>EventProcessor: Trigger Event2
    EventProcessor->>Handler2: Invoke

Loading

Poem

🐰 Hop, hop, events galore!
Handlers dancing through the core
Multiple events, no more strife
CodeRabbit brings code to life!
Efficiency hops with glee 🎉

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7d9bfa3 and b8a2655.

📒 Files selected for processing (2)

• src/ScriptEngine.HostedScript/DefaultEventProcessor.cs (3 hunks)
• tests/events.os (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• tests/events.os
• src/ScriptEngine.HostedScript/DefaultEventProcessor.cs

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.