ethercatmcIndexerAxis.iocsh: Add DESC=$(DESC) to motor template loading

[AndreFavotto]

I would like this line

m-epics-ethercatmc/iocsh/ethercatmcIndexerAxis.iocsh

Line 3 in e3c2bc2

dbLoadRecords("ethercatmc.template", "P=$(P), R=$(R), MOTOR_PORT=$(MOTOR_PORT), ASYN_PORT=$(ASYN_PORT), AXIS_NO=$(AXIS_NO), PREC=$(PREC), RAWENCSTEP_ADEL=$(RAWENCSTEP_ADEL), RAWENCSTEP_MDEL=$(RAWENCSTEP_MDEL) $(ECAXISFIELDINIT)")

To also load the DESC macro, like is done here:

m-epics-ethercatmc/iocsh/ethercatmcAxis.iocsh

Line 35 in e3c2bc2

dbLoadRecords("ethercatmc.template", "P=$(P), R=$(R), AXIS_NO=$(AXIS_NO), MOTOR_PORT=$(MOTOR_PORT), ASYN_PORT=$(ASYN_PORT), AXIS_NO=$(AXIS_NO), DESC=$(DESC), PREC=$(PREC) $(ECAXISFIELDINIT)")

At the moment the code seems to get the DESC field from the PILS TABLE, but for I would like to be able to set my own.

Edit:
Motivation: the DESC field is supposed to describe what the record represents, and using the PILS device name for that (which is what is happening) works, but could be improved with using an actual description, which is what this field is made for.
Example:
PILS name (and current DESC field): SltSet1LftBld
Actual equivalent description: Slit Set 1 - Left Blade

[tboegi]

First reaction: Nope.
Second: More motivation needed.
Third: Create a new iocsh file, with a different name, and use that.

[AndreFavotto]

Hi @tboegi
"Nope" also didn't explain quite a lot on your end... also, I feel like you could use your words a little better :)

The motivation is: the DESC field is supposed to describe what that is, and using the PILS device name for that (which is what is happening) works, but could be improved with using an actual description, which is what this field is made for.
Example:
PILS name (and current DESC field): SltSet1LftBld
Actual equivalent description: Slit Set 1 - Left Blade

If not setting the DESC field through the iocsh file or template, we then should provide a way to set a description through the PILS table instead of just using the PILS device name. Is that an option?

Updated the issue description now.

[tboegi]

The original thinking was
a) to define the description inside the PILS table
b) let that propagate into the DESC field
c) Have a short text to allow the display of all motors of a cabinet at one glance.

What happens if you put "Slit Set 1 - Left Blade" into the PILS table ?

[AndreFavotto]

For me this works as well, but where to define the description in the PILS table?

All the examples I had of PILS tables so far loaded "sName", "asAux" and some other properties, but no description. We are using sName as DESC, but I cant put "Slit Set 1 - Left Blade" as device name, of course...

[AndreFavotto]

Ok, it took me now a bit of ST code digging, but I found this: https://gitlab.esss.lu.se/mcag/sources/tc_pils_generic/-/blob/master/DUTs/ST_DeviceInfo.TcDUT?ref_type=heads#L17

If I put the description I need in the sDESC property in the array of devices should I expect it to be redirected to the record?

[tboegi]

@AndreFavotto : My last comment before vacation:

a)I would propose to have a strong backward compatiblity.
Keep existing iocsh and template files "as is" -
if you want to add another combo with a different name ("v2"),
that could work.
b) If we can fiddle the sDESC into EPICS ?
I don't know without further digging. But warning:
This sDESC is only used used for "param devices", 5010.
We probably want to have a "longer DESC" for all devices ?
And that smells GVL_PILS.
To be continued.

[AndreFavotto]

Agreed.
I will figure out if sDESC is mapped into the records as they are now - this would solve the bigger part of the issue without intervention, since 90% of our axes are motors (5010). If this works, we'd have to think of a way to replicate this behaviour only to pneumatics - 1E04.

The other devices are fine (generic analog inputs and motor temperatures would always be tied to an axis, and they already accept DESC if needed):

m-epics-ethercatmc/iocsh/ethercatmcAnalogInputSmooAdelMdel.iocsh

Line 3 in b7f3a75

dbLoadRecords("ethercatmcAnalogInputSmooAdelMdel.template", "P=$(P), R=$(R), MOTOR_PORT=$(MOTOR_PORT), CHNO=$(CHNO), ASYNPARAMNAME=$(ASYNPARAMNAME), PREC=$(PREC), DESC=$(DESC), EGU=$(EGU), SMOO=$(SMOO), ADEL=$(ADEL), MDEL=$(MDEL)")

m-epics-ethercatmc/iocsh/ethercatmcMotorTemp.iocsh

Line 3 in b7f3a75

dbLoadRecords("ethercatmcMotorTemp.template", "P=$(P), R=$(R), DESC=$(DESC), MOTOR_PORT=$(MOTOR_PORT), AXIS_NO=$(AXIS_NO)")

Note: I agree with not breaking retro-compatibility, but I would like to avoid creating anything like "v2" if possible. To be discussed after vacations!