Skip to content

Latest commit

 

History

History
59 lines (42 loc) · 2.24 KB

File metadata and controls

59 lines (42 loc) · 2.24 KB

Contributing to NitroCraft

Thanks for helping improve NitroCraft. We aim to keep contributions practical, secure, and easy to review.

Before you start

  1. Check for existing issues or pull requests before opening a new one.
  2. Keep changes focused and scoped to one problem.
  3. If you plan a larger change, open an issue first to align approach.
  4. Use Node 24 (.nvmrc / .node-version) and pnpm 10.22.0.

Reporting issues

  1. Use a clear title and describe expected vs actual behavior.
  2. Include reproduction steps, relevant logs, and environment details.
  3. Share version info (node, OS, runtime context such as Docker/Pterodactyl).
  4. If applicable, include request URL examples and response codes.

Pull request guidelines

  1. Keep PRs small and reviewable.
  2. Explain what changed, why it changed, and any risk/compatibility impact.
  3. Update docs/config examples when behavior or configuration changes.
  4. Follow existing project style and file organization.
  5. Prefer root-cause fixes over temporary patches.

Contributor recognition

  1. Contributor Minecraft avatars can be added to the homepage jumbotron sample list.
  2. Pinned contributor entries use data-pinned="true" and are always kept visible in the jumbotron, including on mobile.
  3. If you want to be added, include your Minecraft username/UUID in your PR notes.

Code style

  1. Follow the existing style of the repository.
  2. Keep code readable and consistent.
  3. Prefer clear naming and simple, maintainable implementations.
  4. Add comments only when behavior is non-obvious.

Tests and validation

  1. Add tests for new behavior when feasible (test/unit/*.test.ts).
  2. If fixing a bug, add a test that would have caught it.
  3. Run tests before opening a PR:
  • pnpm test
  1. Ensure your change does not reduce overall reliability.

Security and operations

  1. Never commit secrets (.env, API keys, passwords).
  2. Keep dependency and security changes intentional and documented.
  3. Call out operational changes (cache, retention, Redis, routing, headers) in PR notes.

Final checklist

  1. Code is clean and follows style rules.
  2. Tests/docs updated where needed.
  3. PR description clearly explains impact.
  4. Ready for maintainers to review and merge.