Skip to content

Allow overriding API version #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
c960657 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Allow overriding API version #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6dc8afb
Allow overriding API version
Jul 25, 2016
c22eee8
Remove fields that are not in v201605
Jul 29, 2016
8f26fc4
Show usage of new option
c960657 Oct 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ var Service = new AdWords.ManagedCustomerService({
ADWORDS_REFRESH_TOKEN: 'your refresh token',
ADWORDS_SECRET: 'your secret',
ADWORDS_USER_AGENT: 'your user agent',
version: 'v201605',
});
```

Expand Down
5 changes: 3 additions & 2 deletions adWordsObject.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ function AdWordsObject(options) {
ADWORDS_REFRESH_TOKEN: process.env.ADWORDS_REFRESH_TOKEN,
ADWORDS_SECRET: process.env.ADWORDS_SECRET,
ADWORDS_USER_AGENT: process.env.ADWORDS_USER_AGENT,
verbose: false
verbose: false,
version: 'v201605'
});

// check if all credentials are supplied
Expand All @@ -36,7 +37,7 @@ function AdWordsObject(options) {
self.credentials = null;
self.tokenUrl = 'https://www.googleapis.com/oauth2/v3/token';
self.verbose = self.options.verbose;
self.version = 'v201509';
self.version = self.options.version;

self.refresh = function(done) {
// check if current credentials haven't expired
Expand Down
1 change: 0 additions & 1 deletion services/budgetService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ function Service(options) {
'BudgetStatus',
'DeliveryMethod',
'IsBudgetExplicitlyShared',
'Period'
];

self.xmlns = 'https://adwords.google.com/api/adwords/cm/' + self.version;
Expand Down
2 changes: 0 additions & 2 deletions services/campaignService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ function Service(options) {
};

self.selectable = [
'ActiveViewCpmEnabled',
'AdServingOptimizationStatus',
'AdvertisingChannelSubType',
'AdvertisingChannelType',
Expand All @@ -84,7 +83,6 @@ function Service(options) {
'Labels',
'Level',
'Name',
'Period',
'PricingMode',
'RejectionReasons',
'ServingStatus',
Expand Down