Skip to content

F8E5M2 has 6 NaN values in its range, F8E5M2::is_nan() is checking for only 2 #8

@nayabanjum

Description

@nayabanjum

F8E5M2 has 6 NaN values in its range(0x7D, 0x7E, 0x7F, 0xFD, 0xFE & 0xFF), F8E5M2::is_nan() is checking only 2 (0x7E & 0xFE)

pub const fn is_nan(&self) -> bool { self.0 == 0x7Eu8 || self.0 == 0xFEu8 }

shouldn't it check for all 6 values ?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions