Log Viewer bugs megathread

[edderiofer]

At the moment, the Log Viewer is fully busted.

There are currently three major bugs I'm aware of that are causing this, one after another:

• Some part of the engine asks for a lang parameter, which is assigned in other parts of the game, but never assigned when using the Log Viewer.
  • The solution to this is to put lang={@lang} into every <.live_component \> in /lib/riichi_advanced_web/views/log_live.ex.
• After fixing that, configurable mods are not being parsed correctly. (That is, currently, only those logs of games that did not use any configurable mods can be viewed.
• After fixing that, the condition match(condition, ["win"]) always returns false, so the ron/tsumo buttons never pop up and the log viewer gets confused.

After fixing these three bugs, the Log Viewer should be in a somewhat-usable state.

There are also the following comparatively-more-minor bugs I am aware of (doubtless we will find more after those fixes):

• During a log, kan draws the wrong tile; it draws the third tile from kan_tiles in the log, rather than the first tile, or the tile listed on that timestep's index.
• The log viewer doesn't work with Minefield. We probably want to fix the other bugs before trying to dissect this one.
• The "Back" button in the top right of the "View logs" screen doesn't work. I looked into this and I couldn't figure out why.

[edderiofer]

I've just pushed an update that should make it clear to everyone who attempts to use the log viewer that the log viewer is currently non-functional, and that they should check back later.

UPDATE: Also figured out why the "Back" button wasn't working, and fixed that.