[ 命名建議 ] LeetCode 3. Longest Substring Without Repeating Characters

[LPenny-github]

LeetCode:
https://leetcode.com/problems/longest-substring-without-repeating-characters/

線上教材:
https://blog.techbridge.cc/2019/09/28/leetcode-pattern-sliding-window/

---

再麻煩 @twy30 給予命名建議 orz 感激不盡

using System;
using System.Collections.Generic;

namespace Sandbox
{
    public class Solution
    {
        public int LengthOfLongestSubstring(string s)
        {
            string inputString = s;
            int inputStringLength = inputString.Length;

            if (inputStringLength == 0){ return 0; }
            if (inputStringLength == 1){ return 1; }

            HashSet<char> substring = new HashSet<char>();
            int longestSubstringLength = 0, headIndex = 0, tailIndex = 0;

            while (tailIndex < inputStringLength)
            {
                if (substring.Contains(inputString[tailIndex]))
                {
                    substring.Remove(inputString[headIndex]);
                    ++headIndex;
                }
                else
                {
                    substring.Add(inputString[tailIndex]);
                    longestSubstringLength = Math.Max(longestSubstringLength, tailIndex- headIndex + 1);
                    ++tailIndex;
                }
            }
            return longestSubstringLength;
        }
    }
}

[twy30]

@LPenny-github

你好 😊

---

            int inputStringLength = inputString.Length;

個人感覺 inputString.Length 已經很清楚，可以選擇不再另外宣告一個 inputStringLength 😊

---

            HashSet<char> substring = new HashSet<char>();

這裡我會用 charSet 取代 substring ，因為 "string" 會引導讀者往「這是個 string 物件」的方向去想 (但它事實上是個 HashSet 。

---

這段與命名無關；這裡的 tailIndex- headIndex + 1 可以用 substring.Count 代替。

                    longestSubstringLength = Math.Max(longestSubstringLength, tailIndex- headIndex + 1);

[LPenny-github]

@twy30 學到好多，謝謝大大 orz