Skip to content

Support for removing unused dependencies in constructor dependency injection #599

@rafaeldolfe

Description

@rafaeldolfe
constructor(
        private readonly snackBar: MatSnackBar,
        private readonly securityService: SecurityService,
        private readonly rightPanelService: RightPanelService,
        private readonly angulartics2GoogleAnalytics: Angulartics2GoogleAnalytics,
        private readonly cacheSignalRService: CacheSignalRService,
        private readonly locationService: LocationService,
        private readonly configurationService: ConfigurationService,
        private readonly betaSettingService: BetaSettingService,
        private readonly layoutService: LayoutService,
        private router: Router,
        private readonly titleService: Title,
        private readonly translateService: TranslateService,
        private readonly appTracingHandler: AppTracingHandler,
        private readonly navigationMenuService: NavigationMenuService,
    ) {
        ...
    }

Situations with a bunch of constructor dependency injections that may be unused is not good. Expand the di related eslint rules to also look at constructor dependency injections. Or otherwise refer to another plugin that can?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions