`make: *** No targets specified and no makefile found. Stop.` when following README

[adelton]

The README says

In order to build each image, just cd into the directory and execute make:
% cd dev && make

Since there is a dev directory in this repository, one might be tempted to run that cd dev while in the checkout directory of this repo, to get to that dev. But there is no Makefile there, it is in the top-level directory of the repo instead.

Clearly the instructions want the user to cd into the checkout directory but given the name of the repo is build-edgetx, it is unlikely the directory name is dev.

Would you prefer a PR to remove the cd dev completely, or something like a sequence

git clone https://github.com/EdgeTX/build-edgetx
cd build-edgetx
make

?

[adelton]

The next steps

% cd commit-tests && make

is even weirder. That directory was removed from the repo in 2021 via f7ebcdd and it seems it was replaced by the ghcr.io/edgetx/edgetx-builder image.

So should that step be

make edgetx-builder

?

[pfeerick]

Given the README.md was last updated... what... 4 years ago... it's not surprising it is referencing old stuff.

% cd commit-tests && make

A straight translation would become

% cd builder && make

PR welcome to fix this. I would suggest that it should not spoon feed to much... "How to use" is not "How to checkout the repo".

so perhaps

% cd dev && make
% cd commit-tests && make

would become

make edgetx-dev
make edgetx-builder

But even then, you don't just blindly run those two commands... i.e. you want dev if you are trying to build the build container used to build firmware, and you build builder if you are trying to build the build container used by cloudbuild to build firmware. And then there is the wasi docker that probably needs to be added to Makefile for completeness, which will be used to build simulator plugins in the future.

So perhaps a little more explanation around that is in order?