From 79f9ad07247e25d7e79cc8af315bc5437efeeba1 Mon Sep 17 00:00:00 2001
From: David Pollard <pollardld@gmail.com>
Date: Thu, 21 Nov 2024 16:42:06 -0800
Subject: [PATCH 1/2] Use property name for the zip file name. closes
 https://app.asana.com/0/1202602295746504/1208813611863799/f

---
 landmapper/app/static/landmapper/js/report.js                  | 3 ++-
 .../app/templates/landmapper/report/report-overview.html       | 2 +-
 landmapper/app/views.py                                        | 2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/landmapper/app/static/landmapper/js/report.js b/landmapper/app/static/landmapper/js/report.js
index cc3c28e..0431e4b 100644
--- a/landmapper/app/static/landmapper/js/report.js
+++ b/landmapper/app/static/landmapper/js/report.js
@@ -36,6 +36,7 @@ if (copyToAccountBtn) {
    */
   function exportLayerHandler() {
     const propertyPk = this.getAttribute('data-property-id');
+    const propertyName = this.getAttribute('data-property-name');
     const exportLayerButton = this;
 
     // Disable the button to prevent multiple clicks
@@ -53,7 +54,7 @@ if (copyToAccountBtn) {
         const a = document.createElement('a');
         a.style.display = 'none';
         a.href = url;
-        a.download = `${propertyPk}.zip`;
+        a.download = `${propertyName}.zip`;
         document.body.appendChild(a);
         a.click();
         window.URL.revokeObjectURL(url);
diff --git a/landmapper/app/templates/landmapper/report/report-overview.html b/landmapper/app/templates/landmapper/report/report-overview.html
index 11d39bc..29d70662 100644
--- a/landmapper/app/templates/landmapper/report/report-overview.html
+++ b/landmapper/app/templates/landmapper/report/report-overview.html
@@ -51,7 +51,7 @@ <h2 class="d-print-none">Export your property data</h2>
                     {% if user.is_authenticated and property.user_id == user_id %}
                         
                         <!-- Export Layer Button -->
-                        <button id="export-layer-button" class="btn btn-primary btn-action d-print-none" data-property-id="{{ property.pk }}" aria-label="Dowmload Shape file of Property">
+                        <button id="export-layer-button" class="btn btn-primary btn-action d-print-none" data-property-id="{{ property.pk }}" data-property-name="{{ property_name }}" aria-label="Dowmload Shape file of Property">
                             <img src="{% static 'landmapper/img/icon/icon-shp.svg' %}" class="icon-shp icon" alt="Shape file icon" />
                             {% comment %} <span>SHP</span> {% endcomment %}
                         </button>
diff --git a/landmapper/app/views.py b/landmapper/app/views.py
index 3423725..1f3a35f 100644
--- a/landmapper/app/views.py
+++ b/landmapper/app/views.py
@@ -771,7 +771,7 @@ def export_layer(request, property_pk):
     database_name = settings.DATABASES['default']['NAME']
     sanitized_name = re.sub(r'[^a-zA-Z0-9_-]', '_', property_record.name)
     filename = f"{sanitized_name}"
-    shpdir = os.path.join(settings.SHAPEFILE_EXPORT_DIR, property_pk)
+    shpdir = os.path.join(settings.SHAPEFILE_EXPORT_DIR, sanitized_name)
     os.makedirs(shpdir, exist_ok=True)
 
     try:

From d2f375836b8f3fd60ad3af27c0af82586a541e17 Mon Sep 17 00:00:00 2001
From: David Pollard <pollardld@gmail.com>
Date: Thu, 21 Nov 2024 16:53:24 -0800
Subject: [PATCH 2/2] Use grey for disabled buttons and add login link. Closes
 https://app.asana.com/0/1202602295746504/1208813611863797/f and
 https://app.asana.com/0/1202602295746504/1208813611863798/f

---
 landmapper/app/static/landmapper/css/report.css   |  5 ++++-
 .../landmapper/report/report-overview.html        | 15 +++++++--------
 2 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/landmapper/app/static/landmapper/css/report.css b/landmapper/app/static/landmapper/css/report.css
index 4c444e6..9d55a3b 100644
--- a/landmapper/app/static/landmapper/css/report.css
+++ b/landmapper/app/static/landmapper/css/report.css
@@ -34,7 +34,10 @@ p {
     margin: 4px 0;
   }
 
-  .action-wrap button:disabled {
+  .action-wrap .disabled,
+  .action-wrap :disabled {
+    background: rgba(60, 60, 60, 0.2);
+    opacity: 0.5;
     pointer-events: none;
   }
 
diff --git a/landmapper/app/templates/landmapper/report/report-overview.html b/landmapper/app/templates/landmapper/report/report-overview.html
index 29d70662..c877d97 100644
--- a/landmapper/app/templates/landmapper/report/report-overview.html
+++ b/landmapper/app/templates/landmapper/report/report-overview.html
@@ -50,16 +50,15 @@ <h2 class="d-print-none">Export your property data</h2>
                     
                     {% if user.is_authenticated and property.user_id == user_id %}
                         
-                        <!-- Export Layer Button -->
-                        <button id="export-layer-button" class="btn btn-primary btn-action d-print-none" data-property-id="{{ property.pk }}" data-property-name="{{ property_name }}" aria-label="Dowmload Shape file of Property">
+                        <!-- Export SHP Button -->
+                        <button id="export-layer-button" class="btn btn-primary btn-action d-print-none" data-property-id="{{ property.pk }}" data-property-name="{{ property_name }}" aria-label="Dowmload Shape file of Property" title="Download shape file of property">
                             <img src="{% static 'landmapper/img/icon/icon-shp.svg' %}" class="icon-shp icon" alt="Shape file icon" />
-                            {% comment %} <span>SHP</span> {% endcomment %}
                         </button>
                     
                     {% elif user.is_authenticated and property.user_id != user_id %}
                         
-                        <!-- Export Layer Button -->
-                        <button disabled id="export-layer-button" class="btn btn-primary btn-action d-print-none disabled" aria-label="Dowmload Shape file of Property">
+                        <!-- Export SHP Button -->
+                        <button disabled id="export-layer-button" class="btn btn-primary btn-action d-print-none disabled" aria-label="Dowmload Shape file of Property" title="Copy to your properties to export shape file">
                             <img src="{% static 'landmapper/img/icon/icon-shp.svg' %}" class="icon-shp icon" alt="Shape file icon" />
                         </button>
 
@@ -68,11 +67,12 @@ <h2 class="d-print-none">Export your property data</h2>
                     {% else %}
 
                         <!-- Export Layer Button -->
-                        <button disabled id="export-layer-button" class="btn btn-primary btn-action d-print-none disabled" aria-label="Dowmload Shape file of Property">
+                        <button disabled id="export-layer-button" class="btn btn-primary btn-action d-print-none disabled" aria-label="Dowmload Shape file of Property" title="login to download shape file of property">
                             <img src="{% static 'landmapper/img/icon/icon-shp.svg' %}" class="icon-shp icon" alt="Shape file icon" />
-                            {% comment %} <span>SHP</span> {% endcomment %}
                         </button>
 
+                        <a href="/auth/login/?next=/landmapper/report/{{ property_id }}" class="link-primary" target="_blank"><strong>Login to download</strong></a>
+
                     {% endif %}
 
                 </div>
@@ -94,7 +94,6 @@ <h2 class="d-print-none">Download and share your report</h2>
 
                         <a href="" class="btn btn-primary btn-action d-print-none disabled" target="_blank" aria-label="Download PDF report">
                             <img src="{% static 'landmapper/img/icon/icon-pdf.svg' %}" class="icon-download icon" alt="PDF icon" />
-                            {% comment %} <span>PDF</span> {% endcomment %}
                         </a>
                     
                         <a href="/auth/login/?next=/landmapper/report/{{ property_id }}" class="link-primary" target="_blank"><strong>Login to download</strong></a>