Editor: PH Video Downloader downloads some songs in very low quality

[EIRTeam-Cirno]

mikurisu39_ BOT

https://discord.com/channels/640872911678341130/827646667074306068/1482075915239293060

Lots of songs I've tried to use download in like the lowest quality, and look very blurry. A minority do work fine enough, like when I charted Bibidi Babidi Boo by Honey Popcorn.

I've tried so many songs and only a few have been fine idk.

Screenshot of how it looks in my game will follow rn

[EIRTeam-Cirno]

kurisu BOT

[EIRTeam-Cirno]

EIREXE BOT

For the record these are the command line arguments, it should work 🤔

var format_options: PackedStringArray = PackedStringArray([
    "[ext=mp4][vcodec^=hevc]+bestaudio[ext=m4a]",
    "[ext=webm][vcodec^=vp9]+bestaudio[ext=webm][acodec^=vorb]",
    "[ext=webm][vcodec^=vp9][acodec^=vorb]/best"
])
for i in range(format_options.size()):
    format_options[i] = ("bestvideo[height<=%d][fps<=%d]" % [1080, 60]) + format_options[i]

[EIRTeam-Cirno]

Steven BOT

Since you have a fallback at the end with the /best, why bother specifying all of the other codecs? I assume it has to be failing the first and second formats somehow and picking a low quality merged video on the third check.

But if the game can handle the failure condition where an arbitrary "best" format gets pulled and must be converted to something readable by the game, why would we want to specify anything other than the best format available in the first place?

[EIRTeam-Cirno]

EIREXE BOT

what would you suggest as an alternative? 🤔

[EIRTeam-Cirno]

EIREXE BOT

best is a fallback indeed

[EIRTeam-Cirno]

Steven BOT

if you don't specify it, it'll just pick the best by default
but to filter by a desired height/fps best[height<=%d][fps<=%d] should work
although, filtering the fps is probably unnecessary

[EIRTeam-Cirno]

Steven BOT

the only foreseeable issue would be the codec not being something the game can use, but you could force it to be a specific codec with conditional postprocessing
or force remuxing to a specific format every time via cli args

[EIRTeam-Cirno]

EIREXE BOT

oh yeah it does remux it as a last resort if required

[EIRTeam-Cirno]

Steven BOT

Also, this is the format list for the video of the bug report, if you haven't seen it yet

[EIRTeam-Cirno]

Steven BOT

18 mp4 640x360 24 2 │ ≈ 9.38MiB 355k https │ avc1.42001E mp4a.40.2 44k [ko] 360p
this is the format that actually gets downloaded by the game when running the same args in the terminal

[EIRTeam-Cirno]

Steven BOT

looks like it is failing to the fallback condition, but /best seems to not be grabbing what the documentation implies it should
doing it via the terminal with just -f best yields the same format 🤔

[EIRTeam-Cirno]

Steven BOT

According to the docs, it looks like you should be using /bv*+ba/b instead of /best

[EIRTeam-Cirno]

Steven BOT

Specifying -f at all forces merged audio/video media only unless you specify bestvideo and bestaudio

[EIRTeam-Cirno]

Steven BOT

which is why the other formats normally work fine

[EIRTeam-Cirno]

EIREXE BOT

<@219966809833472010> ok i found the actual issue
the problem is youtube calls h264 hevc or avc1 depending on how it woke up that day