Skip to content

Commit 6afa22f

Browse files
committed
change effect size of chi2 test from phi to cramer's v
1 parent 48f4f25 commit 6afa22f

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

src/modina/context_net_inference.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import logging
99
from typing import Optional, Tuple
1010

11-
EXCLUDED_EFFECTS = {'chi2', 't', 'F', 'U', 'H'}
11+
EXCLUDED_EFFECTS = {'chi2', 'phi', 't', 'F', 'U', 'H'}
1212

1313

1414
def calculate_association_scores(ord_data, nom_data, cont_data, bi_data, test_type='nonparametric', num_workers=1, nan_value=-89) -> pd.DataFrame:
@@ -410,8 +410,11 @@ def _check_input_data(context: pd.DataFrame, meta_file: pd.DataFrame, nan_value:
410410
if nan_value not in existing:
411411
break
412412

413-
logging.warning(f'No nan_value was specified for the context data. For statistical tests, the randomly generated value {nan_value} will be used.'
414-
'If you want to specify a different value, please provide it as an argument.')
413+
logging.warning(f'The context data does not contain any missing values. '
414+
f'For statistical tests, the randomly generated value {nan_value} will be used as '
415+
f'the NaN replacement, as this value does not occur in the data. '
416+
f'If you want to specify a different value, please provide it via the \'nan_value\' argument.'
417+
)
415418

416419
return context, nan_value
417420

0 commit comments

Comments
 (0)