Use gcode Line number to match gcode JSON requests to responses on UART and USB inputs

[T3P3]

Applies to M409 , M32 etc

[dc42]

Implemented in 3.6-dev. JSON responses to commands that were received with a Nxxx prefix now have an additional "line":nnn field. This is normally at the start of the response, but this should not be assumed because the order of fields in a JSON packet is generally not significant. There will be a few instances in which responses are not tagged with line numbers, because messaging functions are called directly e.g. when executing M122. The line number field will be missing in these cases. It will also be missing if the line of GCode received did not have the Nxxx prefix, or if the message was not provoked by a particular line of GCode.

[dc42]

The following commands are reported as not working (i.e. line number missing from reply to a serial device in PanelDue mode):
G28 (runs macros and the macro lines use the same GCode buffer)
M121
echo (line number is not currently added to responses from meta commands because they are processed separately from GCodes)
M98 (if file not found it returns 2 responses, 1 without ID), if file found then a single response without ID)
M702 (as for G28)
M112 (emergency stop broadcasts a message to all channels instead of replying to the original channel)
M486 with no parameters (uses an OutputBuffer instead of the usual reply string, and the changes so far don't handle this case; some other commands also use an OutputBuffer sometimes e.g. M207 M574 M587 M915)

[dc42]

Added code to fix M486 and other commands that use an OutputBuffer for the response. Confirmed working for M486 sent via USB.

Regarding commands that run macros, we would need to record the N line number of the original line that invoked the macro and use that number in replies generated by the macro. Related to #1136.

[chrishamm]

Also implemented in DSF by commit 97869f31be1bb471badbe778f9a3a1bf06929b31. This can be closed if the implementation in RRF (standalone mode) is tested and working.

[dc42]

Now also fixed for commands that run macros and for M121.

[T3P3]

Still outstanding, may not be implemented:

• M112
• M122

This still needs to be fixed:

• M98 when the fie is not found and in JSON response - Warning message has no the line number and empty response does have the line number

[AndyEveritt]

Some testing.

(16:54:16.122) m575 p0 s0
(16:54:16.366) {"seq":1,"resp":"\n"}
(16:54:21.633) n1 m575 p0 s0
(16:54:21.834) {"line":1,"seq":2,"resp":"\n"}
(16:56:05.009) n1 G28 X
(16:56:05.250) {"line":1,"seq":3,"resp":"Homing X\n"}
(16:56:25.019) {"line":1,"seq":4,"resp":"\n"}
(16:56:30.285) n1 echo "test"
(16:56:30.491) {"line":1,"seq":5,"resp":"test\n"}
(16:57:10.001) n1 M98 P"bad"
(16:57:10.253) {"seq":6,"resp":"Warning: Macro file bad not found\n"}
(16:57:10.253) {"line":1,"seq":7,"resp":"\n"}
(16:57:31.956) n1 M121
(16:57:32.161) {"seq":8,"resp":"Error: Pop(): stack underflow on USB\n"}
(16:57:32.161) {"line":1,"seq":9,"resp":"\n"}
(16:57:37.528) n1 M120
(16:57:37.716) {"line":1,"seq":10,"resp":"\n"}
(16:57:39.355) n1 M121
(16:57:39.568) {"line":1,"seq":11,"resp":"\n"}
(16:57:50.546) n1 M702
(16:57:50.837) {"line":1,"seq":12,"resp":"\n"}
(16:57:56.726) n1 M486
(16:57:57.041) {"line":1,"seq":13,"resp":"No known objects on build plate"}

[AndyEveritt]

(17:01:44.861) n1 m36 "QOI.gcode"
(17:01:45.255) {"line":1,"err":0,"fileName":"QOI.gcode","size":712685,"lastModified":"2025-03-18T18:21:58","height":10.25,"layerHeight":0.20,"numLayers":51,"printTime":781,"filament":[1248.7,0.0],"thumbnails":[{"wid
(17:01:45.255) th":32,"height":32,"format":"qoi","offset":106,"size":2884},{"width":400,"height":300,"format":"qoi","offset":3162,"size":48760}],"generatedBy":"PrusaSlicer 2.7.1+win64 on 2024-02-15 at 19:39:07 ","cu
(17:01:45.324) stomInfo":{}}
(17:01:50.616) n1 m36.1 "QOI.gcode"
(17:01:50.833) {"line":1,"seq":14,"resp":"Error: M36.1: missing parameter 'P'\n"}
(17:02:03.641) n1 m36.1 P"QOI.gcode" S106
(17:02:03.842) {"line":1,"thumbnail":{"fileName":"QOI.gcode","offset":106,"data":"cW9pZgAAACAAAAAgBAD/g4OD1v+jo6PC/3FxceD/QEBA/8I//5ycnMbA/5eXl8r/WVlZ8DXC/5eXl8ofIz81wj8m/4qKitEH/0xMTPc1w/+KiorRB/9MTEz3NQf/ioqK0f9MT
(17:02:03.842) Ez3Nf9lZWXo/6Ojo8I/NT8HPzXA/4qKitHA/0xMTPc1Bz81wD8jPzU/NcE//7e3t7UjPzXD/4+Pj87/pqamwP+KiorR/0xMTPc1wj86Bz81wzv/ra2tvP+KiorRNcE/JhHANcI/B/+IiIjTB/9ZWVnwNcIRJhHANcI//5eXl8ofBzX/WVlZ8BE/NcA//5eXl8r/WVlZ8
(17:02:03.842) DU//5eXl8r/TExM9zXAB/9+fn7Z/0BAQP//ZWVl6Ac/NcA/B/9ZWVnwNT//l5eXyhE1/1lZWfD/oaGhw/+Xl5fK/1lZWfA1wgf/o6OjwiY/NcL+Ujg4/65FRej+m0VF/5eXl8oRNcL/WVlZ8DcmPzXCHyM/NcI/JsD/l5eXyv9ZWVnwNQv+iCAg/tEAAMH/sykp8D81w
(17:02:03.842) j8m/4qKitH/l5eXyv9MTEz3NcP/ioqK0Qf/TExM9zUH/35+ftkR/0BAQP//ZWVl6P+0ZmbZ/60QEP8oxP/LFBT3/6JubtkRNQc/NcAj/6Ojo8I/NT81wf9lZWXoAP+jo6PCPzUL/nYoKP6/CAgooFigCP67AACguKAY/s4BAaKYZSj/vEJC5f+Xl5fKPzXDO/+tra28/
(17:02:03.842) 35+ftn/QEBA/8E//5ycnMb/ioqK0f+QdnbZDSgfoDga/p4AAP6BAAD+cAAAoOigyKC4/okBAf6pAgL+zwEBdf/CFBT3/4NhYeD/QEBA/8I/B/+Dg4PWBzX/WVlZ8BE//1I4OP/+mxgYKKBYoAj+tQAA/pQAAP53AAD+bQAAWgUXIyygqDj+jwAA/rwBAf7PAACgGP+bR
(17:02:03.842) UXo/1lZWfD/QEBA/z//l5eXyv9MTEz3Nf9ZWVnw/6GhocP/qY+Pyv+PQUHw/60QEP8oH6AI/rIAADH+bQAAwjmgyBcj","next":1171,"err":0}}
(17:02:13.748) n1 m36.2 P"QOI.gcode" S0
(17:02:13.980) {"line":1,"fragment":{"fileName":"QOI.gcode","offset":0,"err":1}}
(17:02:37.561) n1 m36.2 P"/heightmap.csv" S0
(17:02:37.783) {"line":1,"fragment":{"fileName":"/heightmap.csv","offset":0,"err":1}}
(17:02:48.131) n1 m36.2 P"/sys/DuetScreen/heightmap.csv" S0
(17:02:48.393) {"line":1,"fragment":{"fileName":"/sys/DuetScreen/heightmap.csv","offset":0,"data":"RepRapFirmware height map file v2 generated at 2025-05-13 21:10, min error -0.175, max error 0.349, mean 0.071, devi
(17:02:48.393) ation 0.144\naxis0,axis1,min0,max0,min1,max1,radius,spacing0,spacing1,num0,num1\nX,Y,10.00,290.00,10.00,180.00,-1.00,10.00,10.00,29,18\n  0.033,  0.028,  0.012, -0.033, -0.020,  0.015,  0.012,  0.004,
(17:02:48.393)  -0.004, -0.017, -0.015,  0.007,  0.023,  0.038,  0.057,  0.088,  0.126,  0.176,  0.217,  0.251,  0.268,  0.291,  0.305,  0.319,  0.312,  0.305,  0.326,  0.340,  0.349\n  0.025,  0.017,  0.007,  0.009
(17:02:48.393) ,  0.007,  0.009,  0.012,  0.007, -0.009, -0.017, -0.012,  0.012,  0.023,  0.044,  0.062,  0.093,  0.138,  0.173,  0.217,  0.241,  0.265,  0.279,  0.293,  0.310,  0.305,  0.305,  0.310,  0.312,  0.328
(17:02:48.393) \n  0.009,  0.007,  0.004,  0.001,  0.004,  0.004,  0.001, -0.009, -0.020, -0.028, -0.025, -0.007,  0.012,  0.031,  0.044,  0.077,  0.113,  0.151,  0.198,  0.222,  0.244,  0.263,  0.286,  0.298,  0.30
(17:02:48.393) 0,  0.293,  0.298,  0.300,  0.317\n","next":945,"err":0}}