From 22ce2b897957e3fbad8f86fcc838ce58464d2bc2 Mon Sep 17 00:00:00 2001
From: Daniel Woodward <16451892+DrBarnabus@users.noreply.github.com>
Date: Sun, 15 Feb 2026 11:50:16 +0000
Subject: [PATCH] build: Fix parallel build race on Analyzers.Common deps file
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Add GlobalPropertiesToRemove="TargetFramework" to ProjectReference
items for CompositeKey.Analyzers.Common in multi-targeted projects.
Without this, each parent TFM passes its own TargetFramework as a
global property, causing MSBuild to treat them as separate build
requests that can run concurrently—all writing to the same
netstandard2.0 output directory and racing on the .deps.json file.
---
 .../CompositeKey.Analyzers.Common.UnitTests.csproj              | 2 +-
 .../CompositeKey.Analyzers.UnitTests.csproj                     | 2 +-
 src/CompositeKey.Analyzers/CompositeKey.Analyzers.csproj        | 2 +-
 .../CompositeKey.SourceGeneration.csproj                        | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/CompositeKey.Analyzers.Common.UnitTests/CompositeKey.Analyzers.Common.UnitTests.csproj b/src/CompositeKey.Analyzers.Common.UnitTests/CompositeKey.Analyzers.Common.UnitTests.csproj
index 8cb5791..8612f52 100644
--- a/src/CompositeKey.Analyzers.Common.UnitTests/CompositeKey.Analyzers.Common.UnitTests.csproj
+++ b/src/CompositeKey.Analyzers.Common.UnitTests/CompositeKey.Analyzers.Common.UnitTests.csproj
@@ -34,7 +34,7 @@
 
     <ItemGroup>
         <ProjectReference Include="..\CompositeKey\CompositeKey.csproj" />
-        <ProjectReference Include="..\CompositeKey.Analyzers.Common\CompositeKey.Analyzers.Common.csproj" />
+        <ProjectReference Include="..\CompositeKey.Analyzers.Common\CompositeKey.Analyzers.Common.csproj" GlobalPropertiesToRemove="TargetFramework" />
     </ItemGroup>
 
 </Project>
diff --git a/src/CompositeKey.Analyzers.UnitTests/CompositeKey.Analyzers.UnitTests.csproj b/src/CompositeKey.Analyzers.UnitTests/CompositeKey.Analyzers.UnitTests.csproj
index 9b95b7d..d2a3a17 100644
--- a/src/CompositeKey.Analyzers.UnitTests/CompositeKey.Analyzers.UnitTests.csproj
+++ b/src/CompositeKey.Analyzers.UnitTests/CompositeKey.Analyzers.UnitTests.csproj
@@ -36,7 +36,7 @@
     <ItemGroup>
         <ProjectReference Include="..\CompositeKey\CompositeKey.csproj" />
         <ProjectReference Include="..\CompositeKey.Analyzers\CompositeKey.Analyzers.csproj" />
-        <ProjectReference Include="..\CompositeKey.Analyzers.Common\CompositeKey.Analyzers.Common.csproj" />
+        <ProjectReference Include="..\CompositeKey.Analyzers.Common\CompositeKey.Analyzers.Common.csproj" GlobalPropertiesToRemove="TargetFramework" />
     </ItemGroup>
 
 </Project>
diff --git a/src/CompositeKey.Analyzers/CompositeKey.Analyzers.csproj b/src/CompositeKey.Analyzers/CompositeKey.Analyzers.csproj
index 8b95517..02c19a5 100644
--- a/src/CompositeKey.Analyzers/CompositeKey.Analyzers.csproj
+++ b/src/CompositeKey.Analyzers/CompositeKey.Analyzers.csproj
@@ -23,7 +23,7 @@
     </ItemGroup>
 
     <ItemGroup>
-        <ProjectReference Include="..\CompositeKey.Analyzers.Common\CompositeKey.Analyzers.Common.csproj" PrivateAssets="all" ReferenceOutputAssembly="true" />
+        <ProjectReference Include="..\CompositeKey.Analyzers.Common\CompositeKey.Analyzers.Common.csproj" PrivateAssets="all" ReferenceOutputAssembly="true" GlobalPropertiesToRemove="TargetFramework" />
     </ItemGroup>
 
     <Target Name="GetPackAsAnalyzerFiles" DependsOnTargets="$(GenerateNuspecDependsOn);GetCommonAssemblyPath" Returns="@(PackAsAnalyzerFile)">
diff --git a/src/CompositeKey.SourceGeneration/CompositeKey.SourceGeneration.csproj b/src/CompositeKey.SourceGeneration/CompositeKey.SourceGeneration.csproj
index 96ab4bc..a7d6177 100644
--- a/src/CompositeKey.SourceGeneration/CompositeKey.SourceGeneration.csproj
+++ b/src/CompositeKey.SourceGeneration/CompositeKey.SourceGeneration.csproj
@@ -23,7 +23,7 @@
     </ItemGroup>
 
     <ItemGroup>
-        <ProjectReference Include="..\CompositeKey.Analyzers.Common\CompositeKey.Analyzers.Common.csproj" PrivateAssets="all" ReferenceOutputAssembly="true" />
+        <ProjectReference Include="..\CompositeKey.Analyzers.Common\CompositeKey.Analyzers.Common.csproj" PrivateAssets="all" ReferenceOutputAssembly="true" GlobalPropertiesToRemove="TargetFramework" />
     </ItemGroup>
 
     <ItemGroup>