Skip to content

Commit 8f3cb9a

Browse files
committed
fix: small fixes to tizen_player and tizen_video_player_controls
fixed it so pause and play in TizenPlayer does not return an empty future cleaned up tizen_video_player_controls - removed commented out code.
1 parent fa2bc19 commit 8f3cb9a

2 files changed

Lines changed: 5 additions & 26 deletions

File tree

lib/screens/video_player/tizen_video_player_controls.dart

Lines changed: 3 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ class _TVControlsState extends ConsumerState<TVControls> {
189189
break;
190190
case 'seekBack':
191191
final backwardSpeed =
192-
ref.read(userProvider.select((value) => value?.userSettings?.skipBackDuration.inSeconds ?? 10));
192+
ref.read(userProvider.select((value) => value?.userSettings?.skipBackDuration.inSeconds ?? 30));
193193
seekBack(ref, seconds: backwardSpeed);
194194
break;
195195
case 'playPause':
@@ -698,8 +698,8 @@ class _TVControlsState extends ConsumerState<TVControls> {
698698
}
699699

700700
Widget seekBackwardButton(WidgetRef ref) {
701-
final backwardSpeed = 10;
702-
//ref.read(userProvider.select((value) => value?.userSettings?.skipBackDuration.inSeconds ?? 30));
701+
final backwardSpeed =
702+
ref.read(userProvider.select((value) => value?.userSettings?.skipBackDuration.inSeconds ?? 30));
703703
return _wrapNav(
704704
'seekBack',
705705
IconButton(
@@ -901,36 +901,15 @@ class _TVControlsState extends ConsumerState<TVControls> {
901901
resetTimer();
902902
return true;
903903
}
904-
// if (key == LogicalKeyboardKey.arrowUp) {
905-
// // Move up a few steps (best-effort grid movement)
906-
// _moveSelection(-3);
907-
// return true;
908-
// }
909-
// if (key == LogicalKeyboardKey.arrowDown) {
910-
// _moveSelection(3);
911-
// return true;
912-
// }
913-
// Activation keys
914904

915905
if (key == LogicalKeyboardKey.select || key == LogicalKeyboardKey.enter || key == LogicalKeyboardKey.space) {
916-
//activateSelection();
917-
//_setActiveIndicator('Activate');
918906
resetTimer();
919907
return true;
920908
}
921909
}
922910

923-
// // Arrow keys -> seek indicator (when overlay not visible)
924-
// if (key == LogicalKeyboardKey.arrowLeft || key == LogicalKeyboardKey.arrowRight) {
925-
// _setActiveIndicator('Seek');
926-
// // do not swallow here; other handlers (seek indicator) will process the key
927-
// return false;
928-
// }
929-
930911
// Up/Down -> volume (when overlay not visible)
931912
if (key == LogicalKeyboardKey.arrowUp || key == LogicalKeyboardKey.arrowDown || key == LogicalKeyboardKey.select || key == LogicalKeyboardKey.enter || key == LogicalKeyboardKey.space) {
932-
// _setActiveIndicator('Volume');
933-
// do not swallow here; allow normal processing
934913
toggleOverlay(value: true);
935914
return false;
936915
}

lib/wrappers/players/tizen_player.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,9 @@ class TizenPlayer extends BasePlayer {
8282
}
8383

8484
@override
85-
Future<void> pause() => _controller?.pause() ?? Future.value();
85+
Future<void> pause() async => _controller?.pause();
8686
@override
87-
Future<void> play() => _controller?.play() ?? Future.value();
87+
Future<void> play() async => _controller?.play();
8888
@override
8989
Future<void> playOrPause() async => lastState.playing ? _controller?.pause() : _controller?.play();
9090
@override

0 commit comments

Comments
 (0)