refactor: replace stack-based window title management with a key-based registry

Author: schembriaiden

lib/providers/video_player_provider.dart

@@ -5,6 +5,7 @@ import 'package:flutter/material.dart';
 
 import 'package:flutter_riverpod/flutter_riverpod.dart';
 import 'package:path/path.dart' as p;
+
 import 'package:fladder/models/media_playback_model.dart';
 import 'package:fladder/models/playback/playback_model.dart';
 import 'package:fladder/providers/settings/client_settings_provider.dart';

lib/providers/window_title_provider.dart

@@ -1,41 +1,41 @@
 import 'dart:io';
 import 'package:flutter/foundation.dart';
 import 'package:flutter_riverpod/flutter_riverpod.dart';
+import 'package:fladder/models/media_playback_model.dart';
+import 'package:fladder/providers/video_player_provider.dart';
 import 'package:window_manager/window_manager.dart';
 
 /// Manages the context-aware window title.
 final windowTitleProvider = StateNotifierProvider<WindowTitleNotifier, String>((ref) {
-  return WindowTitleNotifier();
+  return WindowTitleNotifier(ref);
 });
 
 class WindowTitleNotifier extends StateNotifier<String> {
-  WindowTitleNotifier() : super('Fladder');
+  final Ref ref;
+  WindowTitleNotifier(this.ref) : super('Fladder');
 
-  final List<String> _navStack = [];
+  final Map<Object, String> _titles = {};
+  final List<Object> _stackKeys = [];
   String? _playTitle;
 
-  void pushNavTitle(String title) {
-    _navStack.add(title);
+  void updateTitle(Object key, String title) {
+    _stackKeys.remove(key);
+    _stackKeys.add(key);
+    _titles[key] = title;
     _update();
   }
 
-  void popNavTitle(String title) {
-    _navStack.remove(title);
-    _update();
-  }
-
-  void replaceNavTitle(String oldTitle, String newTitle) {
-    final index = _navStack.lastIndexOf(oldTitle);
-    if (index != -1) {
-      _navStack[index] = newTitle;
-    } else {
-      _navStack.add(newTitle);
+  void removeTitle(Object key) {
+    final removed = _stackKeys.remove(key);
+    _titles.remove(key);
+    if (removed) {
+      _update();
     }
-    _update();
   }
 
   void clearStack() {
-    _navStack.clear();
+    _stackKeys.clear();
+    _titles.clear();
     _update();
   }
 
@@ -45,17 +45,30 @@ class WindowTitleNotifier extends StateNotifier<String> {
   }
 
   void _update() {
-    final nav = _navStack.isNotEmpty ? _navStack.last : null;
-    final title = _playTitle ?? nav;
+    final nav = _stackKeys.isNotEmpty ? _titles[_stackKeys.last] : null;
+    final playerState = ref.read(mediaPlaybackProvider).state;
 
-    if (kIsWeb) {
-      state = title != null ? 'Fladder • $title' : 'Fladder';
-    } else {
-      state = title ?? 'Fladder';
-    }
+    final isPlayerActive = playerState != VideoPlayerState.disposed;
+    final isPlayerMinimized = playerState == VideoPlayerState.minimized;
+
+    // Use playTitle if player is active and expanded/fullscreen.
+    // If player is minimized or inactive, prefer navigation title.
+    final title = (isPlayerActive && !isPlayerMinimized) 
+        ? (_playTitle ?? nav) 
+        : (nav ?? _playTitle);
+
+    final newState = kIsWeb ? (title != null ? 'Fladder • $title' : 'Fladder') : (title ?? 'Fladder');
+
+    if (state == newState) return;
+
+    Future.microtask(() {
+      state = newState;
+    });
 
     if (!kIsWeb && (Platform.isLinux || Platform.isMacOS || Platform.isWindows)) {
-      windowManager.setTitle(state);
+      // Setting window title directly is safe even during build
+      windowManager.setTitle(newState);
     }
   }
+
 }

lib/screens/shared/detail_scaffold.dart

@@ -73,29 +73,40 @@ class _DetailScaffoldState extends ConsumerState<DetailScaffold> {
   ImageProvider? _lastRequestedImage;
   ImageData? _lastColorImage;
 
+  String? _currentTitle;
+
+  void _pushTitle() {
+    final isCurrent = ModalRoute.of(context)?.isCurrent ?? false;
+    if (!isCurrent) return;
+
+    final newTitle = widget.windowTitle ?? widget.item?.windowTitle(context.localized) ?? widget.label;
+    if (newTitle.isNotEmpty) {
+      _currentTitle = newTitle;
+      ref.read(windowTitleProvider.notifier).updateTitle(this, newTitle);
+    }
+  }
+
   @override
   void initState() {
     super.initState();
-    WidgetsBinding.instance.addPostFrameCallback((_) {
-      ref.read(windowTitleProvider.notifier).pushNavTitle(widget.windowTitle ?? widget.label);
-    });
+  }
+
+  @override
+  void didChangeDependencies() {
+    super.didChangeDependencies();
+    _pushTitle();
   }
 
   @override
   void dispose() {
-    ref.read(windowTitleProvider.notifier).popNavTitle(widget.windowTitle ?? widget.label);
+    ref.read(windowTitleProvider.notifier).removeTitle(this);
     super.dispose();
   }
 
   @override
   void didUpdateWidget(covariant DetailScaffold oldWidget) {
     super.didUpdateWidget(oldWidget);
-    if (oldWidget.label != widget.label || oldWidget.windowTitle != widget.windowTitle) {
-      ref.read(windowTitleProvider.notifier).replaceNavTitle(
-            oldWidget.windowTitle ?? oldWidget.label,
-            widget.windowTitle ?? widget.label,
-          );
-    }
+    _pushTitle();
     updateImage();
     _updateDominantColor();
     if (widget.item != null && widget.item?.id != item?.id) {

lib/widgets/navigation_scaffold/navigation_scaffold.dart

@@ -52,7 +52,6 @@ class _NavigationScaffoldState extends ConsumerState<NavigationScaffold> {
     super.initState();
     WidgetsBinding.instance.addPostFrameCallback((value) {
       ref.read(viewsProvider.notifier).fetchViews();
-      ref.read(windowTitleProvider.notifier).clearStack();
     });
   }
 
@@ -124,7 +123,7 @@ class _NavigationScaffoldState extends ConsumerState<NavigationScaffold> {
               child: Builder(builder: (context) {
                 return Scaffold(
                   key: _key,
-                  appBar: fullScreenChildRoute ? null : const FladderAppBar(),
+                  appBar: fullScreenChildRoute ? null : FladderAppBar(label: currentIndex == -1 ? "" : null),
                   extendBodyBehindAppBar: true,
                   resizeToAvoidBottomInset: false,
                   extendBody: true,