Skip to content

Commit 4de575e

Browse files
Remmelt Pitremmelt
authored andcommitted
feat: support for multiple containers for a single ECS task definition
1 parent bdf6598 commit 4de575e

1 file changed

Lines changed: 9 additions & 7 deletions

File tree

engine/ecs.go

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -87,13 +87,15 @@ func (engine *ECSDeploymentEngine) Deploy(config Deployment, p func(string, ...a
8787

8888
func generateRegisterTaskDefinitionInput(taskDefinition *types.TaskDefinition, version string, versionEnvironmentKey string) *ecs.RegisterTaskDefinitionInput {
8989
containerDefinitions := taskDefinition.ContainerDefinitions
90-
imageName := strings.Split(*containerDefinitions[0].Image, ":")[0]
91-
containerDefinitions[0].Image = aws.String(imageName + ":" + version)
92-
if versionEnvironmentKey != "" {
93-
containerDefinitions[0].Environment = append(containerDefinitions[0].Environment, types.KeyValuePair{
94-
Name: aws.String(versionEnvironmentKey),
95-
Value: aws.String(version),
96-
})
90+
for i := range containerDefinitions {
91+
imageName := strings.Split(*containerDefinitions[i].Image, ":")[0]
92+
containerDefinitions[i].Image = aws.String(imageName + ":" + version)
93+
if versionEnvironmentKey != "" {
94+
containerDefinitions[i].Environment = append(containerDefinitions[i].Environment, types.KeyValuePair{
95+
Name: aws.String(versionEnvironmentKey),
96+
Value: aws.String(version),
97+
})
98+
}
9799
}
98100
registerTaskDefinitionInput := &ecs.RegisterTaskDefinitionInput{
99101
Family: taskDefinition.Family,

0 commit comments

Comments
 (0)